Skip to content

fix: restore ped_id in acceleration plot legend label#540

Merged
chraibi merged 1 commit into
PedestrianDynamics:mainfrom
chraibi:fix-acceleration-label
May 20, 2026
Merged

fix: restore ped_id in acceleration plot legend label#540
chraibi merged 1 commit into
PedestrianDynamics:mainfrom
chraibi:fix-acceleration-label

Conversation

@chraibi
Copy link
Copy Markdown
Collaborator

@chraibi chraibi commented May 20, 2026

The label was "Ped ID ".format(ped_id), replaced with an f-string so each line is correctly labelled.

The label was "Ped ID ".format(ped_id), a silent no-op because the
string has no {} placeholder, so the legend showed "Ped ID " with
no id. Replace with an f-string so each line is correctly labelled.
Copilot AI review requested due to automatic review settings May 20, 2026 13:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores the pedestrian ID being included in the legend label for the acceleration time-series plot in the user guide notebook, so each plotted line is correctly identified.

Changes:

  • Replace a broken .format(...) usage with an f-string for the acceleration plot legend label.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread notebooks/user_guide.ipynb
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (d362055) to head (6adcf0b).

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chraibi chraibi merged commit 8cb1d3e into PedestrianDynamics:main May 20, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants