Skip to content

ServiceControl.Contracts require overriding the conventions #453

@danielmarbach

Description

@danielmarbach

Describe the suggested improvement

ServiceControl.Contracts require overriding conventions like shown below

var conventions = endpointConfiguration.Conventions();
conventions.DefiningEventsAs(
    type =>
    {
        return typeof(IEvent).IsAssignableFrom(type) ||
               // include ServiceControl events
               type.Namespace != null &&
               type.Namespace.StartsWith("ServiceControl.Contracts");
    });

because they do not use the marker interfaces. Historically this made sense because we wanted to avoid tight coupling to NServiceBus. With the introduction of MessageInterfaces this seems no longer necessary, and we could release a new version of the contracts that references NServiceBus.MessageInterfaces which then would mean all the convention code is no longer required.

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions