Skip to content

Commit eb766a2

Browse files
committed
Fix: final fix question mark??
1 parent afb0c6a commit eb766a2

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

src/api/api.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -264,15 +264,11 @@ async def update_zone(zone_id: int, update: UpdateZone):
264264
@self.app.delete("/cameras/{camera_id}")
265265
async def delete_camera(camera_id: int):
266266
try:
267-
camera = self.db_manager.get_camera(camera_id)
268-
269-
if camera is None:
267+
if self.db_manager.delete_camera(camera_id) == 0:
270268
raise HTTPException(
271269
status_code=status.HTTP_404_NOT_FOUND,
272270
detail=f"Camera with id {camera_id} doesn't exist"
273271
)
274-
275-
self.db_manager.delete_camera(camera)
276272
except HTTPException:
277273
raise
278274
except Exception as e:

src/db_manager/db_manager.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,10 @@ def update_zone(self, zone_id, update_zone):
361361

362362
return zone.serialize() if zone is not None else None
363363

364-
def delete_camera(self, camera):
364+
def delete_camera(self, camera_id):
365365
with self.get_session() as session:
366-
session.delete(camera)
367-
session.commit()
366+
res = session.query(Camera).filter(Camera.id == camera_id).delete()
367+
368+
session.commit()
369+
370+
return res

0 commit comments

Comments
 (0)