current ch4 has issues when executed by liberty (19.0.0.9 till LATEST) but working in quarkus 2.3.1.Final

[amhambra]

note: I changed port to 8080.

issue 1: can not load the test data in

@PostConstruct
com.packt.microprofile.book.ch4.client.MPRestClient.initThesaurus()

so call to

http://localhost:8080/ch4/rest/thesaurus/funny

results in

funny

issue 2: exception on MPRestClient

Call to

http://localhost:8080/ch4/rest/client/mp/loud

results in

[INFO] [err] javax.ws.rs.WebApplicationException: HTTP 404 Not Found
[INFO] [err] at org.apache.cxf.microprofile.client.DefaultResponseExceptionMapper.toThrowable(DefaultResponseExceptionMapper.java:33)
[INFO] [err] at [internal classes]
[INFO] [err] at org.apache.cxf.microprofile.client.proxy.MicroProfileClientProxyImpl.access$000(MicroProfileClientProxyImpl.java:76)
[INFO] [err] at org.apache.cxf.microprofile.client.proxy.MicroProfileClientProxyImpl$Invoker.call(MicroProfileClientProxyImpl.java:510)
[INFO] [err] at [internal classes]
[INFO] [err] at com.sun.proxy.$Proxy69.setSynonymsFor(Unknown Source)
[INFO] [err] at com.packt.microprofile.book.ch4.client.MPRestClient.initThesaurus(MPRestClient.java:78)
[INFO] [err] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[INFO] [err] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[INFO] [err] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[INFO] [err] at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[INFO] [err] at org.jboss.weld.injection.producer.DefaultLifecycleCallbackInvoker.invokeMethods(DefaultLifecycleCallbackInvoker.java:83)
[INFO] [err] at [internal classes]
[INFO] [err] at javax.servlet.http.HttpServlet.service(HttpServlet.java:686)
[INFO] [err] at com.ibm.websphere.jaxrs.server.IBMRestServlet.service(IBMRestServlet.java:96)
[INFO] [err] at [internal classes]
[INFO] [err] at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
[INFO] [err] at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
[INFO] [err] at java.base/java.lang.Thread.run(Thread.java:829)
[INFO] [err] com.packt.microprofile.book.ch4.thesaurus.NoSuchWordException:
[INFO]

[INFO]
[INFO] [err] at com.packt.microprofile.book.ch4.client.NoSuchWordResponseMapper.toThrowable(NoSuchWordResponseMapper.java:20)
[INFO] [err] at com.packt.microprofile.book.ch4.client.NoSuchWordResponseMapper.toThrowable(NoSuchWordResponseMapper.java:10)
[INFO] [err] at org.apache.cxf.microprofile.client.proxy.MicroProfileClientProxyImpl.checkResponse(MicroProfileClientProxyImpl.java:197)
[INFO] [err] at [internal classes]
[INFO] [err] at org.apache.cxf.microprofile.client.proxy.MicroProfileClientProxyImpl.access$000(MicroProfileClientProxyImpl.java:76)
[INFO] [err] at org.apache.cxf.microprofile.client.proxy.MicroProfileClientProxyImpl$Invoker.call(MicroProfileClientProxyImpl.java:510)
[INFO] [err] at [internal classes]
[INFO] [err] at com.sun.proxy.$Proxy69.getSynonymsFor(Unknown Source)
[INFO] [err] at com.packt.microprofile.book.ch4.client.MPRestClient.synonymsFor(MPRestClient.java:31)
[INFO] [err] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[INFO] [err] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[INFO] [err] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[INFO] [err] at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[INFO] [err] at com.ibm.ws.jaxrs20.cdi.component.JaxRsFactoryImplicitBeanCDICustomizer.serviceInvoke(JaxRsFactoryImplicitBeanCDICustomizer.java:351)
[INFO] [err] at [internal classes]
[INFO] [err] at javax.servlet.http.HttpServlet.service(HttpServlet.java:686)
[INFO] [err] at com.ibm.websphere.jaxrs.server.IBMRestServlet.service(IBMRestServlet.java:96)
[INFO] [err] at [internal classes]
[INFO] [err] at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
[INFO] [err] at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
[INFO] [err] at java.base/java.lang.Thread.run(Thread.java:829)

solution: adapting quarkus starter project pom.xml and put it to work with unchanged code

note: Adapted code to use quarkus default port 8080.

Here both issues are away and expected results are coming.

info: no change on code apart from default port 8080.

[amhambra]

See pull to get ch4 working on quarkus 2.3.1.Final.

[andymc12]

Hi @amhambra - thanks for raising this issue. The problem is not with Liberty, but a bug in the sample code that is not using the correct "ch4" context root. As for why it works in quarkus - my guess is that quarkus doesn't use context roots based on the war file by default. I have a fix that I tested locally in PR #8. Would you like to give it a try before I merge?

As for PR #7, I'm not opposed to adding a quarkus option, but I would like to keep the code working on Open Liberty by default since that is what is described in the book. Thanks again for the issue and PR!

[amhambra]

Hi @andymc12 - glad to help as I learn much from the book.
Checked out pr8 and tested. Now it is working fine without my code changes.
You can merge from my view.

I will work on my changes further to get other MicroProfile Runtimes running, as I intend a POC to go with this as rest client best practices (wip).

One Question: It is intended to not use the Interface to be implemented by the Resources Class? This got me on the wrong track as it is not clear which class is the implementing one.

Cheers,
Frank

[andymc12]

Hi @amhambra - thanks for the review and testing the changes. I'll go ahead and merge.

I will work on my changes further to get other MicroProfile Runtimes running, as I intend a POC to go with this as rest client best practices (wip).

This sounds great!

One Question: It is intended to not use the Interface to be implemented by the Resources Class? This got me on the wrong track as it is not clear which class is the implementing one.

It can, but it doesn't have to. For some of the samples, I prefer that they don't implement them - that way it is (hopefully) a little clearer that the client interface can be used with any RESTful service - even services written in other languages or frameworks.

The MP Rest Client implementations (usually CXF, RESTEasy, or Jersey - packaged in app servers like Open Liberty, Quarkus, etc.) provide the implementation of the client interface by using dynamic proxies or other mechanisms (code generation is another approach, but I don't know of any implementation that uses this approach).

Hope this helps - and thanks again for implementing this for other servers. Please let me know when you are ready for review.