refactor: remove unused structure validation logic from Validate-Settings.ps1

Author: MariusStorhaug

tests/Validate-Settings.ps1

@@ -26,78 +26,3 @@ if (-not $isValid) {
     exit 1
 }
 Write-Host '✓ Settings conform to JSON schema'
-
-# Load expected reference settings
-Write-Host 'Comparing with reference settings...'
-$referencePath = Join-Path $PSScriptRoot 'Settings.json'
-$expectedSettings = Get-Content $referencePath -Raw | ConvertFrom-Json
-
-function Test-ObjectStructure {
-    <#
-    .SYNOPSIS
-        Compares the structure of two objects.
-
-    .DESCRIPTION
-        Recursively compares the structure of an actual object against an expected object,
-        validating that all expected properties exist in the actual object.
-
-    .OUTPUTS
-        System.String[]
-        Returns an array of error messages for any structural mismatches.
-    #>
-    [CmdletBinding()]
-    param(
-        # The actual object to validate.
-        $Actual,
-
-        # The expected object structure to validate against.
-        $Expected,
-
-        # The current path in the object hierarchy (used for error reporting).
-        $Path = 'Root'
-    )
-
-    $errors = @()
-
-    # Get all properties from expected object
-    $expectedProps = $Expected.PSObject.Properties.Name
-    foreach ($prop in $expectedProps) {
-        $currentPath = "$Path.$prop"
-
-        if (-not $Actual.PSObject.Properties.Name.Contains($prop)) {
-            $errors += "Missing property: $currentPath"
-            continue
-        }
-
-        $actualValue = $Actual.$prop
-        $expectedValue = $Expected.$prop
-
-        # Check if both are objects (not arrays or primitives)
-        if ($expectedValue -is [PSCustomObject] -and $actualValue -is [PSCustomObject]) {
-            $errors += Test-ObjectStructure -Actual $actualValue -Expected $expectedValue -Path $currentPath
-        } elseif ($expectedValue -is [array] -and $actualValue -is [array]) {
-            # For arrays, just verify they're both arrays - don't compare contents
-            Write-Host "  ✓ Array property: $currentPath"
-        } elseif ($null -eq $expectedValue -and $null -eq $actualValue) {
-            # Both null is fine
-            Write-Host "  ✓ Null property: $currentPath"
-        } elseif (($null -eq $expectedValue -and $null -ne $actualValue) -or ($null -ne $expectedValue -and $null -eq $actualValue)) {
-            # One null, one not - this is an error
-            $errors += "Null mismatch at $currentPath (Expected null: $($null -eq $expectedValue), Actual null: $($null -eq $actualValue))"
-        }
-    }
-
-    return $errors
-}
-
-$structureErrors = Test-ObjectStructure -Actual $settings -Expected $expectedSettings
-
-if ($structureErrors.Count -gt 0) {
-    Write-Host ''
-    Write-Host "Structure validation failed with $($structureErrors.Count) error(s):" -ForegroundColor Red
-    $structureErrors | ForEach-Object { Write-Host "  - $_" -ForegroundColor Red }
-    Write-Error 'Settings structure does not match expected layout. See errors above.'
-    exit 1
-}
-
-Write-Host '✓ Settings structure matches expected layout'