refactor: improve error handling for null property mismatches in Validate-Settings.ps1

Author: MariusStorhaug

scripts/main.ps1

@@ -254,11 +254,13 @@ if ($settings.Test.Skip) {
     LogGroup 'Module Local Test Suites:' {
         $moduleTestSuites = if ($settings.Test.Module.Skip) {
             Write-Host 'Skipping all module tests.'
+            $null
         } else {
             # Locate the tests directory.
             $testsPath = Resolve-Path 'tests' -ErrorAction SilentlyContinue | Select-Object -ExpandProperty Path
             if (-not $testsPath) {
                 Write-Warning 'No tests found'
+                return $null
             }
             Write-Host "Tests found at [$testsPath]"
 

tests/Validate-Settings.ps1

@@ -82,8 +82,8 @@ function Test-ObjectStructure {
             # Both null is fine
             Write-Host "  ✓ Null property: $currentPath"
         } elseif (($null -eq $expectedValue -and $null -ne $actualValue) -or ($null -ne $expectedValue -and $null -eq $actualValue)) {
-            # One null, one not - this might be okay depending on context
-            Write-Host "  ⚠ Null mismatch at $currentPath (Expected: $($null -eq $expectedValue), Actual: $($null -eq $actualValue))"
+            # One null, one not - this is an error
+            $errors += "Null mismatch at $currentPath (Expected null: $($null -eq $expectedValue), Actual null: $($null -eq $actualValue))"
         }
     }