fix(node-ui): restore context graph detail origins#599
Merged
Conversation
8 tasks
There was a problem hiding this comment.
Codex review produced 3 comment(s) but all targeted lines outside the diff and were dropped. Check the workflow logs for details.
719247b to
5525545
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectView, with stable scroll keys on the actual scroll roots used by restoration.Related
Files changed
packages/node-ui/src/ui/views/ProjectView.tsxpackages/node-ui/src/ui/views/project/components.tsxpackages/node-ui/test/project-view-navigation.test.tspackages/node-ui/test/ka-detail-label.test.tsTest plan
pnpm --filter @origintrail-official/dkg-node-ui exec vitest run test/project-view-navigation.test.ts test/ka-detail-label.test.ts test/ui-compat.test.ts test/use-memory-entities-live-updates.test.ts test/use-memory-entities-partial.test.tspnpm --filter @origintrail-official/dkg-node-ui run buildpnpm --filter @origintrail-official/dkg-node-ui run build:uigit diff --checkhttp://localhost:5176/ui/with no console errors or warnings.Note: the local dev node had zero context graphs, so the full live drill-in/back walkthrough still needs a populated-node manual pass.