-
Notifications
You must be signed in to change notification settings - Fork 187
feat( protocol-designer, step-generation): timeline errors for flex stacker steps #20317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: edge
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## edge #20317 +/- ##
==========================================
- Coverage 25.78% 25.77% -0.02%
==========================================
Files 3625 3636 +11
Lines 301800 303125 +1325
Branches 42290 42430 +140
==========================================
+ Hits 77827 78118 +291
- Misses 223944 224978 +1034
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| const labwareIdOnModule = getLabwareIdOnHopper(labware, moduleLocation) | ||
| const labwarePythonName = labwareEntities[labwareIdOnModule]?.pythonName | ||
| // TODO: add error creator if there is no labware in the hopper | ||
| // TODO: add error for if there is labware on the shuttle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good either way, but do you plan to wire up this error in this PR? I think we can create a utility in step-generation/src/utils/misc.ts that accesses the module's state. Something like:
export const getLabwareIdOnShuttle = (
stackerState: FlexStackerModuleState
): string | null => {
return stackerState.labwareOnShuttle?.primaryLabwareId ?? null
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Nick. ya, up to you Rhyann! you can address multiple timeline errors in this PR if you want. But if you wire this up, can you also add a unit test for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on it!
| }, | ||
| labware: { | ||
| [mockLabwareId]: { | ||
| stack: ['D2'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this isn't a valid stack, it should include the labwareId itself in it. so something like this: this means mockLabwareId is directly on the slot.
| stack: ['D2'], | |
| stack: [mockLabwareId, 'D2'], |
| } | ||
| } | ||
|
|
||
| export const flexStackerHopperEmpty = (): CommandCreatorError => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool thanks for adding all the error types in here 😄
Overview
Timeline errors for flex stacker steps
Test Plan and Hands on Testing
Changelog
HOPPER_EMPTY,SHUTTLE_EMPTY,SHUTTLE_FULLandMISMATCHED_LABWAREReview requests
Risk assessment
Partially closes EXEC-2083 and EXEC-2084 until it can be tested in the UI