Skip to content

fix: Pacman provider uses unrecognized option '--update' #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fmichea wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Pacman provider uses unrecognized option '--update' #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/puppet/provider/package/pacman.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ def install_from_file
else
fail _("Source %{source} is not supported by pacman") % { source: source }
end
pacman "--noconfirm", "--noprogressbar", "--update", source
pacman "--noconfirm", "--noprogressbar", "--upgrade", source
end

def install_from_repo
Expand Down
4 changes: 2 additions & 2 deletions spec/unit/provider/package/pacman_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
resource[:source] = source

expect(executor).to receive(:execute).
with(include("--update") & include(source), no_extra_options).
with(include("--upgrade") & include(source), no_extra_options).
ordered.
and_return("")

Expand All @@ -116,7 +116,7 @@

it "should install from the path segment of the URL" do
expect(executor).to receive(:execute).
with(include("--update") & include(actual_file_path), no_extra_options).
with(include("--upgrade") & include(actual_file_path), no_extra_options).
ordered.
and_return("")

Expand Down