chore: increment/reset login_failed_attempt count

Author: matiasperrone-exo

app/Http/Controllers/UserController.php

@@ -411,7 +411,7 @@ public function postLogin()
             if (isset($data['password']))
                 $data['password'] = trim($data['password']);
 
-            $login_attempts = intval(Request::input('login_attempts'));
+            $login_attempts = (int) Session::get('captcha_failed_attempts', 0);
             // Build the validation constraint set.
             $rules = [
                 'username' => 'required|email',
@@ -436,7 +436,9 @@ public function postLogin()
                 $connection = $data['connection'] ?? null;
 
                 try {
+                    $user = $this->auth_service->getUserByUsername($username);
                     if ($flow == "password" && $this->auth_service->login($username, $password, $remember)) {
+                        $user->setLoginFailedAttempt(0);
                         return $this->login_strategy->postLogin();
                     }
 
@@ -467,16 +469,15 @@ public function postLogin()
                         }
 
                         $otpClaim = OAuth2OTP::fromParams($username, $connection, $password);
+
                         $this->auth_service->loginWithOTP($otpClaim, $client);
+                        $user?->setLoginFailedAttempt(0);
                         return $this->login_strategy->postLogin();
                     }
                 } catch (AuthenticationException $ex) {
                     // failed login attempt...
 
-                    $user = $this->auth_service->getUserByUsername($username);
-                    if (!is_null($user)) {
-                        $login_attempts = $user->getLoginFailedAttempt();
-                    }
+                    $login_attempts = $user?->updateLoginFailedAttempt() ?? 0;
 
                     return $this->login_strategy->errorLogin
                     (
@@ -505,7 +506,7 @@ public function postLogin()
                 'validator'                         => $validator,
             ];
 
-            if (is_null($user) && isset($data['username'])) {
+            if (is_null($user) && !empty($data['username'])) {
                 $user = $this->auth_service->getUserByUsername($data['username']);
             }