chore: remove BaseEntity oveloaded props and methods. fix skipped test

Author: matiasperrone-exo

app/libs/Auth/Models/TwoFactorAuditLog.php

@@ -13,12 +13,13 @@
  * limitations under the License.
  **/
 
+use App\Models\Utils\BaseEntity;
 use Auth\User;
 use Doctrine\ORM\Mapping as ORM;
 
 #[ORM\Table(name: 'two_factor_audit_log')]
 #[ORM\Entity(repositoryClass: \App\Repositories\DoctrineTwoFactorAuditLogRepository::class)]
-class TwoFactorAuditLog
+class TwoFactorAuditLog extends BaseEntity
 {
     public const EventChallengeIssued = 'challenge_issued';
     public const EventChallengeSucceeded = 'challenge_succeeded';
@@ -55,11 +56,6 @@ class TwoFactorAuditLog
         self::MethodRecovery,
     ];
 
-    #[ORM\Id]
-    #[ORM\GeneratedValue]
-    #[ORM\Column(name: 'id', type: 'integer', unique: true, nullable: false)]
-    protected $id;
-
     #[ORM\JoinColumn(name: 'user_id', referencedColumnName: 'id', onDelete: 'CASCADE')]
     #[ORM\ManyToOne(targetEntity: \Auth\User::class)]
     private $user;
@@ -79,20 +75,13 @@ class TwoFactorAuditLog
     #[ORM\Column(name: 'metadata', type: 'json', nullable: true)]
     private $metadata;
 
-    #[ORM\Column(name: 'created_at', type: 'datetime')]
-    private $created_at;
 
     public function __construct()
     {
-        $this->created_at = new \DateTime('now', new \DateTimeZone('UTC'));
+        parent::__construct();
         $this->metadata = null;
     }
 
-    public function getId(): int
-    {
-        return (int) $this->id;
-    }
-
     public function getUser(): User
     {
         return $this->user;
@@ -158,9 +147,4 @@ public function setMetadata(?array $value): void
     {
         $this->metadata = $value;
     }
-
-    public function getCreatedAt(): \DateTime
-    {
-        return $this->created_at;
-    }
 }

app/libs/Auth/Models/UserRecoveryCode.php

@@ -35,16 +35,12 @@ class UserRecoveryCode extends BaseEntity
 
     public function __construct()
     {
-        $this->created_at = new \DateTime('now', new \DateTimeZone('UTC'));
+        parent::__construct();
         $this->used_at = null;
     }
 
-    public function getId(): int
-    {
-        return (int) $this->id;
-    }
 
-    public function getUser(): User
+    public function getUser(): ?User
     {
         return $this->user;
     }
@@ -73,10 +69,6 @@ public function getUsedAt(): ?\DateTime
         return $this->used_at;
     }
 
-    public function getCreatedAt(): \DateTime
-    {
-        return $this->created_at;
-    }
 
     public function isUsed(): bool
     {

tests/TwoFactorRepositoriesTest.php

@@ -375,7 +375,9 @@ public function testMarkUsedTwiceThrows(): void
 
     public function testSetCodeHashRejectsPlaintext(): void
     {
-        $this->markTestSkipped('setCodeHash() was removed from UserRecoveryCode; plaintext validation no longer has an entry point.');
+        $code = new UserRecoveryCode();
+        $this->expectException(\InvalidArgumentException::class);
+        $code->setCodeHash('plaintext-not-a-hash');
     }
 
     // -------------------------------------------------------------------------