Old UI doesn't let you set DMX address of a one slot device to 512

[peternewman]

See the original report here:
https://groups.google.com/forum/#!topic/open-lighting/Vf2kRA1PMII

Interestingly it does work via the RDM Patcher.

It would appear we've got an off by one error here:
https://github.com/OpenLightingProject/ola/blob/master/olad/RDMHTTPModule.cpp#L2107

The returned JSON is:
{ "error": "", "items": [ { "description": "DMX Start Address", "id": "address", "max": 511, "min": 0, "type": "uint", "value": 512 } ], "refresh": true }

It also allows you to set the address -1, and then gets NAcked by the responder.

@nomis52 is there some reason behind this, or is it just a straight bug?

[peternewman]

Full UI is here:
https://github.com/OpenLightingProject/ola/blob/master/javascript/ola/full/rdm_attributes_panel.js#L370

The mobile UI has the same issue (but the undefined test fails, on Chrome at least, so we don't get an error):
https://github.com/OpenLightingProject/ola/blob/master/javascript/ola/mobile/universe_tab.js#L360

So they're both currently inclusive ranges, but we're off by one when passing that.

[peternewman]

Main bug fixed. I just need to look at "the undefined test fails on the mobile UI, on Chrome at least, so we don't get an error".

[peternewman]

I think I have a fix for the mobile UI issue here: #1053