Fix arm64 build against current macOS SDK#33
Open
an1310 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Switch Pro controller HID handler has a struct field typed as an
output-report enum, but compares it against an input-report enum value.
Older compilers tolerated the mismatch; current clang rejects it under
-Werroras a comparison of different enumeration types, which breaksthe build.
The struct holds an acknowledgement received from the controller, so the
field should be the input-report type. Corrected accordingly. Both enums
are
uint8_t-backed, so there is no layout or ABI change.Builds arm64 against the macOS 26 SDK.