Skip to content

Commit 021614b

Browse files
committed
Fix 9 TS errors - Misc validators, helpers, endpoints
Fixed remaining TypeScript compilation errors: - request-builders.spec.ts: Removed incorrect null parameter (1 fix) - base-types.ts: Exported Event type (1 fix) - edr/helpers.ts: Added string type check before 'in' operator (3 fixes) - endpoint.ts: Added string type check for DateTimeParameter (2 fixes) - stac/endpoint.ts: Added string type check for DateTimeParameter (2 fixes) All fixes handle DateTimeParameter string literals ('now', 'latest') before using 'in' operator which requires object types. Resolves Sam-Bolling/CSAPI-Live-Testing#79
1 parent ab66e52 commit 021614b

5 files changed

Lines changed: 10 additions & 1 deletion

File tree

src/ogc-api/csapi/request-builders.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ describe('Request Builders', () => {
400400
expect(() =>
401401
buildPropertyBody(
402402
{ uid: 'test', featureType: 'InvalidType' } as any,
403-
null,
403+
404404
{ validate: true, strict: true }
405405
)
406406
).toThrow();

src/ogc-api/csapi/sensorml/base-types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
import type { GeoJsonProperties } from 'geojson';
1313
import type { Event } from './event';
14+
export type { Event } from './event';
1415

1516
/**
1617
* Web link structure used for references between SensorML objects

src/ogc-api/edr/helpers.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ export function DateTimeParameterToEDRString(param: DateTimeParameter): string {
77
return format(param);
88
}
99

10+
if (typeof param === 'string') {
11+
return param; // 'now' or 'latest'
12+
}
13+
1014
if ('start' in param && 'end' in param) {
1115
return `${format(param.start)}/${format(param.end)}`;
1216
}

src/ogc-api/endpoint.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -629,6 +629,8 @@ ${e.message}`);
629629
'datetime',
630630
dateTime instanceof Date
631631
? dateTime.toISOString()
632+
: typeof dateTime === 'string'
633+
? dateTime
632634
: `${'start' in dateTime ? dateTime.start.toISOString() : '..'}/${
633635
'end' in dateTime ? dateTime.end.toISOString() : '..'
634636
}`

src/stac/endpoint.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,8 @@ export default class StacEndpoint {
144144
'datetime',
145145
dateTime instanceof Date
146146
? dateTime.toISOString()
147+
: typeof dateTime === 'string'
148+
? dateTime
147149
: `${'start' in dateTime ? dateTime.start.toISOString() : '..'}/${
148150
'end' in dateTime ? dateTime.end.toISOString() : '..'
149151
}`

0 commit comments

Comments
 (0)