Merge pull request #63 from ONS-Innovation/KEH-1276

fix(megalint): update configs + version bump

Author: TotalDwarf03

.checkov.yml

@@ -17,6 +17,10 @@ skip-check:
   # Pin module sources to a commit hash (false positive)
   - CKV_TF_1
 
+  # Ignore unrestricted egress to any IP address
+  # SPP use the same pattern so it's not a concern for us
+  - CKV_AWS_382
+
   # These ignores are TEMPORARY. They will be resolved in the future.
   - CKV_AWS_108
   - CKV_AWS_272

.github/workflows/megalinter.yml

@@ -85,7 +85,8 @@ jobs:
 
         # You can override MegaLinter flavor used to have faster performances
         # More info at https://megalinter.io/latest/flavors/
-        uses: oxsecurity/megalinter@1fc052d03c7a43c78fe0fee19c9d648b749e0c01
+        # The below commit hash is v8.8.0
+        uses: oxsecurity/megalinter@e08c2b05e3dbc40af4c23f41172ef1e068a7d651
 
         id: ml
 

.mega-linter.yml

@@ -28,9 +28,6 @@ DISABLE_LINTERS:
   - REPOSITORY_TRUFFLEHOG
   - REPOSITORY_GIT_DIFF
 
-  # Conflicting with Prettier
-  - MARKDOWN_MARKDOWN_TABLE_FORMATTER
-
   # Disabled due to false positives
   - MARKDOWN_MARKDOWN_LINK_CHECK
 

Makefile

@@ -62,7 +62,7 @@ megalint:  ## Run the mega-linter.
 	docker run --platform linux/amd64 --rm \
 		-v /var/run/docker.sock:/var/run/docker.sock:rw \
 		-v $(shell pwd):/tmp/lint:rw \
-		oxsecurity/megalinter:v7
+		oxsecurity/megalinter:v8
 
 .PHONY: mypy
 mypy:  ## Run mypy.

README.md

@@ -193,7 +193,7 @@ Further information can be found in [this project's documentation](/docs/index.m
    **Example Output:**
 
    | REPOSITORY                  | TAG    | IMAGE ID     | CREATED        | SIZE  |
-   | --------------------------- | ------ | ------------ | -------------- | ----- |
+   |-----------------------------|--------|--------------|----------------|-------|
    | copilot-usage-lambda-script | latest | 0bbe73d9256f | 11 seconds ago | 224MB |
 
 3. Run the image locally mapping local host port (9000) to container port (8080) and passing in AWS credentials to download a .pem file from the AWS Secrets Manager to the running container. These credentials will also be used to upload and download `historic_usage_data.json` to and from S3.
@@ -233,7 +233,7 @@ Further information can be found in [this project's documentation](/docs/index.m
    **Example output:**
 
    | CONTAINER ID | IMAGE                       | COMMAND                | CREATED        | STATUS        | PORTS                                     | NAMES        |
-   | ------------ | --------------------------- | ---------------------- | -------------- | ------------- | ----------------------------------------- | ------------ |
+   |--------------|-----------------------------|------------------------|----------------|---------------|-------------------------------------------|--------------|
    | 3f7d64676b1a | copilot-usage-lambda-script | "/lambda-entrypoint.…" | 44 seconds ago | Up 44 seconds | 0.0.0.0:9000->8080/tcp, :::9000->8080/tcp | nice_ritchie |
 
    Stop the container