Add parameter to allow commit by default in jobs

False on new databases, True on existing databases.
Should always be False by default on future versions.

Author: guewen

queue_job/__manifest__.py

@@ -21,6 +21,7 @@
         "views/queue_job_menus.xml",
         "data/queue_data.xml",
         "data/queue_job_function_data.xml",
+        "data/ir_config_parameter_data.xml",
     ],
     "assets": {
         "web.assets_backend": [

queue_job/data/ir_config_parameter_data.xml

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo noupdate="1">
+    <record id="allow_commit_by_default" model="ir.config_parameter">
+        <field name="key">queue_job.allow_commit_by_default</field>
+        <field name="value">False</field>
+    </record>
+</odoo>

queue_job/migrations/18.0.2.2.0/post-migration.py

@@ -0,0 +1,13 @@
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html)
+from openupgradelib import openupgrade
+
+
+@openupgrade.migrate()
+def migrate(env, version):
+    if not version:
+        return
+
+    env["ir.config_parameter"].sudo().set_param(
+        "queue_job.allow_commit_by_default", True
+    )
+    env["queue.job.function"].search([]).write({"allow_commit": True})

queue_job/models/queue_job_function.py

@@ -7,6 +7,7 @@
 from collections import namedtuple
 
 from odoo import _, api, exceptions, fields, models, tools
+from odoo.tools import str2bool
 
 from ..fields import JobSerialized
 
@@ -81,6 +82,7 @@ def _default_channel(self):
         "See the module description for details.",
     )
     allow_commit = fields.Boolean(
+        default=lambda self: self._default_allow_commit_by_default(),
         help="Allows the job to commit transactions during execution. "
         "Under the hood, this executes the job in a new database cursor, "
         "which incurs a slight overhead.",
@@ -155,7 +157,19 @@ def job_default_config(self):
             related_action_func_name=None,
             related_action_kwargs={},
             job_function_id=None,
-            allow_commit=False,
+            allow_commit=self._default_allow_commit_by_default(),
+        )
+
+    @api.model
+    def _default_allow_commit_by_default(self):
+        # We shoud not allow commit by default on job functions, this parameter
+        # is here for backward compatibility, a migration sets it by default on
+        # existing databases, but new databases will have it set to False by
+        # default.
+        return str2bool(
+            self.env["ir.config_parameter"]
+            .sudo()
+            .get_param("queue_job.allow_commit_by_default")
         )
 
     def _parse_retry_pattern(self):