Skip to content

Commit f369ed9

Browse files
committed
fix(coderabbit): tighten review path guidance
1 parent 44a145c commit f369ed9

1 file changed

Lines changed: 26 additions & 21 deletions

File tree

.coderabbit.yaml

Lines changed: 26 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -226,22 +226,25 @@ reviews:
226226
files. If generated output is wrong or missing, identify the generator/source
227227
input and require regeneration in the same PR. If source model changes without
228228
matching generated artifacts, flag it.
229-
- path: "**/*.yaml"
230-
instructions: OpenTelemetry/TypeSpec convention models. Validate schema shape,
231-
stability names, attribute reuse, generated-output consistency, and that changes
232-
regenerate all emitted C#/TS/docs artifacts through the documented generator.
233-
- path: "**/*.yml"
234-
instructions: OpenTelemetry/TypeSpec convention models. Validate schema shape,
235-
stability names, attribute reuse, generated-output consistency, and that changes
236-
regenerate all emitted C#/TS/docs artifacts through the documented generator.
229+
- path: "**/semconv/**/*.yaml"
230+
instructions: OpenTelemetry semantic-convention YAML. Validate schema shape, stability
231+
names, attribute reuse, generated-output consistency, and regenerated downstream
232+
artifacts.
233+
- path: "**/semconv/**/*.yml"
234+
instructions: OpenTelemetry semantic-convention YAML. Validate schema shape, stability
235+
names, attribute reuse, generated-output consistency, and regenerated downstream
236+
artifacts.
237+
- path: "**/model/**/*.yaml"
238+
instructions: OpenTelemetry semantic-convention model YAML. Validate schema shape,
239+
stability names, attribute reuse, generated-output consistency, and regenerated
240+
downstream artifacts.
241+
- path: "**/models/**/*.yaml"
242+
instructions: OpenTelemetry semantic-convention model YAML. Validate schema shape,
243+
stability names, attribute reuse, generated-output consistency, and regenerated
244+
downstream artifacts.
237245
- path: "**/*.tsp"
238-
instructions: OpenTelemetry/TypeSpec convention models. Validate schema shape,
239-
stability names, attribute reuse, generated-output consistency, and that changes
240-
regenerate all emitted C#/TS/docs artifacts through the documented generator.
241-
- path: "**/*.json"
242-
instructions: OpenTelemetry/TypeSpec convention models. Validate schema shape,
243-
stability names, attribute reuse, generated-output consistency, and that changes
244-
regenerate all emitted C#/TS/docs artifacts through the documented generator.
246+
instructions: TypeSpec contracts. Validate API/schema contract drift, generated-output
247+
consistency, and documented generator usage.
245248
- path: Pipeline/**
246249
instructions: NUKE generation/release pipeline. Keep fluent C# targets, typed
247250
parameters, no raw shell, and generator outputs reproducible.
@@ -343,11 +346,13 @@ reviews:
343346
repo uses one.'
344347
- mode: error
345348
name: CI Release Safety
346-
instructions: 'Pass/fail criteria: fail workflow/build/release changes that
347-
reduce required validation, introduce admin bypasses, broaden token permissions
348-
without justification, leak secrets, remove concurrency where needed, make
349-
publish steps run on the wrong trigger, or allow failed required checks to
350-
be ignored.'
349+
instructions: 'Pass/fail criteria: if no workflow/build/release files changed,
350+
pass. Fail when a changed workflow removes an existing validation job, removes
351+
concurrency from push/PR workflows, adds --admin/force-push/bypass commands,
352+
increases token permissions beyond contents:read without inline rationale,
353+
exposes secrets in command arguments/logs, changes publish triggers to run
354+
outside tags or approved environments, or allows a previously required failing
355+
check to be ignored.'
351356
- mode: warning
352357
name: Tests Match Risk
353358
instructions: 'Pass/fail criteria: warn when production behavior changes without
@@ -524,7 +529,7 @@ knowledge_base:
524529
pull_requests:
525530
scope: global
526531
mcp:
527-
usage: enabled
532+
usage: auto
528533
linked_repositories:
529534
- repository: ANcpLua/ANcpLua.Agents
530535
instructions: Related ANcpLua/O-ANcppLua repository. Use for cross-repo API, package,

0 commit comments

Comments
 (0)