Skip to content

self_loop on the start state is redundant  #3

@roys174

Description

@roys174

The model doesn't add the restart_padding for the self-loop diagonal. This creates a small bug for in the plus-times semiring, as the model is considering matches starting from the beginning and taking multiple self-loops.

A simple solution is to give the first self-loop a fixed score of one. Similarly, we could do the same for the final self-loop, and avoid the max/sum-pooling of the final hidden states.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions