Skip to content

4 iOS Cropper Issues #256

@renatomserra

Description

@renatomserra

Having a few Issues with cropper!

Setup:

 "@baronha/react-native-multiple-image-picker": "2.2.5",
 "react-native": "0.79.7",

1 - Getting the following crash in production when using cropper

const response = await openCropper(processedPath, {freeStyle: true});
          Crashed: com.apple.main-thread
0  DogCatApp                      0x9b5a1c EditorViewController.removeVideo() + 1329 (EditorViewController.swift:1329)
1  DogCatApp                      0x9b5f14 @objc EditorViewController.__deallocating_deinit + 1336 (EditorViewController.swift:1336)
2  libsystem_blocks.dylib         0x18a0 bool HelperBase<ExtendedInline>::disposeCapture<(HelperBase<ExtendedInline>::BlockCaptureKind)3>(unsigned int, unsigned char*) + 68
3  libsystem_blocks.dylib         0x16f0 HelperBase<GenericInline>::destroyBlock(Block_layout*, bool, unsigned char*) + 116
4  libsystem_blocks.dylib         0x1470 _call_dispose_helpers_excp + 72
5  libsystem_blocks.dylib         0x11e8 _Block_release + 236
6  libsystem_blocks.dylib         0x1920 bool HelperBase<ExtendedInline>::disposeCapture<(HelperBase<ExtendedInline>::BlockCaptureKind)4>(unsigned int, unsigned char*) + 68
7  libsystem_blocks.dylib         0x1740 HelperBase<GenericInline>::destroyBlock(Block_layout*, bool, unsigned char*) + 196
8  libsystem_blocks.dylib         0x1470 _call_dispose_helpers_excp + 72
9  libsystem_blocks.dylib         0x11e8 _Block_release + 236
10 CoreFoundation                 0x11a28 <redacted> + 116
11 CoreFoundation                 0x117e0 <redacted> + 148
12 UIKitCore                      0xb43f0 <redacted> + 144
13 UIKitCore                      0xca4ff8 <redacted> + 204
14 UIKitCore                      0x19639bc <redacted> + 180
15 UIKitCore                      0x1963750 <redacted> + 852
16 UIKitCore                      0x8f2a4 __UIVIEW_IS_EXECUTING_ANIMATION_COMPLETION_BLOCK__ + 36
17 UIKitCore                      0x198a960 <redacted> + 628
18 UIKitCore                      0x196a168 <redacted> + 260
19 UIKitCore                      0x196a5cc <redacted> + 192
20 UIKitCore                      0x196a63c <redacted> + 304
21 QuartzCore                     0xe3da4 <redacted> + 132
22 libdispatch.dylib              0x1b7ec _dispatch_client_callout + 16
23 libdispatch.dylib              0x38b24 _dispatch_main_queue_drain.cold.5 + 812
24 libdispatch.dylib              0x10ec8 _dispatch_main_queue_drain + 180
25 libdispatch.dylib              0x10e04 _dispatch_main_queue_callback_4CF + 44
26 CoreFoundation                 0x6a2c8 <redacted> + 16
27 CoreFoundation                 0x1db3c <redacted> + 1944
28 CoreFoundation                 0x1ca6c <redacted> + 532
29 GraphicsServices               0x1498 GSEventRunModal + 120
30 UIKitCore                      0x9dba4 <redacted> + 792
31 UIKitCore                      0x46a78 UIApplicationMain + 336
32 DogCatApp                      0x578c main + 10 (AppDelegate.swift:10)
33 ???                            0x18e0c2e28 (Missing)

which seems to be resolved by adding a fake delay to call cropper after picker (react-native-image-picker), which isnt ideal as i dont know if it wil work for every device

2- Cancelling open cropper never solves, so i dont know when to remove my loading state

3- For some reason some images get rotated after cropping, i think its portrait shots

4- Seems Circle and freeStyle dont do anything? Would be great to be able to set freeForm as a default

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions