Merge pull request #17 from NextStepFinalProject/NXD-19

Hotfix Local Register And Login

Author: taljacob2

nextstep-backend/src/services/users_service.ts

@@ -49,7 +49,7 @@ export const deleteUserById = async (id: string): Promise<UserData | null> => {
     return user ? userToUserData(user) : null;
 };
 
-export const registerUser = async (username: string, password: string, email: string, authProvider: string): Promise<UserData> => {
+export const registerUser = async (username: string, password: string, email: string, authProvider: string = "local"): Promise<UserData> => {
     let hashedPassword: string = '';
     // If registering with a password (local registration)
     if (password && authProvider === 'local') {
@@ -102,14 +102,14 @@ export const loginUserGoogle = async (email: string, authProvider: string, name:
     return {...tokens, userId: user.id, username: user.username, imageFilename: user.imageFilename}
 }
 
-export const loginUser = async (email: string, password: string, authProvider?: string): Promise<{ accessToken: string, refreshToken: string, userId: string, username: string, imageFilename?: string } | null> => {
+export const loginUser = async (email: string, password: string, authProvider: string = "local"): Promise<{ accessToken: string, refreshToken: string, userId: string, username: string, imageFilename?: string } | null> => {
     const user = await getIUserByEmail(email);
     if (!user) {
         return null;
     }
      // Local login (with password)
      if (authProvider === 'local') {
-        if ((await bcrypt.compare(password, user.password))) {
+        if (!(await bcrypt.compare(password, user.password))) {
             return null;
         }
      }