Skip to content

Commit aae0747

Browse files
Srivastava, PiyushSrivastava, Piyush
authored andcommitted
more fixes
1 parent 000cc1d commit aae0747

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,6 @@ public class OntapPrimaryDatastoreDriver implements PrimaryDataStoreDriver {
6565

6666
@Inject private StoragePoolDetailsDao storagePoolDetailsDao;
6767
@Inject private PrimaryDataStoreDao storagePoolDao;
68-
@Inject private com.cloud.storage.dao.VolumeDao volumeDao;
69-
@Inject private EndPointSelector epSelector;
7068

7169
@Override
7270
public Map<String, String> getCapabilities() {
@@ -317,5 +315,4 @@ private StorageStrategy getStrategyByStoragePoolDetails(Map<String, String> deta
317315
throw new CloudRuntimeException("getStrategyByStoragePoolDetails: Connection to Ontap SVM [" + details.get(Constants.SVM_NAME) + "] failed");
318316
}
319317
}
320-
321-
}
318+
}

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/Svm.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,4 +144,4 @@ public int hashCode() {
144144
@JsonInclude(JsonInclude.Include.NON_NULL)
145145
public static class Links { }
146146

147-
}
147+
}

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedNASStrategy.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -390,18 +390,14 @@ private Answer createVolumeOnKVMHost(VolumeInfo volumeInfo) {
390390

391391
try {
392392
s_logger.info("createVolumeOnKVMHost: Sending CreateObjectCommand to KVM agent for volume: {}", volumeInfo.getUuid());
393-
// Create command with volume TO (Transfer Object)
394393
CreateObjectCommand cmd = new CreateObjectCommand(volumeInfo.getTO());
395-
// Select endpoint (KVM agent) to send command
396-
// epSelector will find an appropriate KVM host in the cluster/pod
397394
EndPoint ep = epSelector.select(volumeInfo);
398395
if (ep == null) {
399396
String errMsg = "No remote endpoint to send CreateObjectCommand, check if host is up";
400397
s_logger.error(errMsg);
401398
return new Answer(cmd, false, errMsg);
402399
}
403400
s_logger.info("createVolumeOnKVMHost: Sending command to endpoint: {}", ep.getHostAddr());
404-
// Send command to KVM agent and wait for response
405401
Answer answer = ep.sendMessage(cmd);
406402
if (answer != null && answer.getResult()) {
407403
s_logger.info("createVolumeOnKVMHost: Successfully created qcow2 file on KVM host");

0 commit comments

Comments
 (0)