CSTACKEX-35 Added Loggers

Author: Gupta, Surya

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

@@ -104,7 +104,7 @@ public void createAsync(DataStore dataStore, DataObject dataObject, AsyncComplet
         }
 
        try {
-           logger.info("createAsync: Volume creation starting for data store [{}] and data object [{}] of type [{}]",
+           logger.info("createAsync starting for data store [{}] and data object [{}] of type [{}]",
                     dataStore, dataObject, dataObject.getType());
            if (dataObject.getType() == DataObjectType.VOLUME) {
                 path = createCloudStackVolume(dataStore.getId(), dataObject);
@@ -116,15 +116,17 @@ public void createAsync(DataStore dataStore, DataObject dataObject, AsyncComplet
            }
        } catch (Exception e) {
             errMsg = e.getMessage();
-            logger.error("createAsync: Volume creation failed for dataObject [{}]: {}", dataObject, errMsg);
+            logger.error("createAsync failed for dataObject [{}]: {}", dataObject, errMsg);
             createCmdResult = new CreateCmdResult(null, new Answer(null, false, errMsg));
             createCmdResult.setResult(e.toString());
        } finally {
+           logger.info("createAsync completed");
             callback.complete(createCmdResult);
        }
     }
 
     private String createCloudStackVolume(long storagePoolId, DataObject dataObject) {
+        logger.info("createCloudStackVolume starting for storagePoolId {} and data object [{}]", storagePoolId, dataObject);
         String path = null;
         StoragePoolVO storagePool = storagePoolDao.findById(storagePoolId);
         if(storagePool == null) {
@@ -156,6 +158,7 @@ private String createCloudStackVolume(long storagePoolId, DataObject dataObject)
         } else {
             throw new CloudRuntimeException("createCloudStackVolume : ONTAP details validation failed, cannot connect to ONTAP cluster");
         }
+        logger.info("createCloudStackVolume completed with path {}", path);
         return path;
     }
 

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedSANStrategy.java

@@ -78,7 +78,8 @@ public Lun createLUN(String svmName, String volumeName, String lunName, long siz
                 throw new CloudRuntimeException("Failed to create Lun: " + lunName);
             }
             Lun lun = createdLun.getRecords().get(0);
-            logger.info("LUN created successfully. Lun: {}", lun);
+            logger.debug("LUN created successfully. Lun: {}", lun);
+            logger.info("LUN created successfully. LunName: {}", lun.getName());
             return lun;
         } catch (Exception e) {
             logger.error("Exception occurred while creating LUN: {} under volume {} for SVM: {}. Exception: {}", lunName, volumeName, svmName, e.getMessage());