[pbxFile] implement option for weak linked frameworks

Author: goya

lib/pbxFile.js

@@ -80,6 +80,9 @@ function pbxFile(filepath, opt) {
 
     this.sourceTree = opt.sourceTree || defaultSourceTree(this);
     this.fileEncoding = opt.fileEncoding || fileEncoding(this);
+
+    if (opt.weak && opt.weak === true) 
+      this.settings = { ATTRIBUTES: ['Weak'] };
 }
 
 module.exports = pbxFile;

lib/pbxProject.js

@@ -485,6 +485,7 @@ function pbxBuildFileObj(file) {
     obj.isa = 'PBXBuildFile';
     obj.fileRef = file.fileRef;
     obj.fileRef_comment = file.basename;
+    if (file.settings) obj.settings = file.settings;
 
     return obj;
 }

test/addFramework.js

@@ -85,9 +85,22 @@ exports.addFramework = {
         test.equal(buildFileEntry.isa, 'PBXBuildFile');
         test.equal(buildFileEntry.fileRef, newFile.fileRef);
         test.equal(buildFileEntry.fileRef_comment, 'libsqlite3.dylib');
+        test.equal(buildFileEntry.settings, undefined);
 
         test.done();
     },
+    'should add the PBXBuildFile object correctly /w weak linked frameworks': function (test) {
+        var newFile = proj.addFramework('libsqlite3.dylib', { weak: true }),
+            buildFileSection = proj.pbxBuildFileSection(),
+            buildFileEntry = buildFileSection[newFile.uuid];
+
+        test.equal(buildFileEntry.isa, 'PBXBuildFile');
+        test.equal(buildFileEntry.fileRef, newFile.fileRef);
+        test.equal(buildFileEntry.fileRef_comment, 'libsqlite3.dylib');
+        test.deepEqual(buildFileEntry.settings, { ATTRIBUTES: [ 'Weak' ] });
+        
+        test.done();
+    },
     'should add to the Frameworks PBXGroup': function (test) {
         var newLength = proj.pbxGroupByName('Frameworks').children.length + 1,
             newFile = proj.addFramework('libsqlite3.dylib'),

test/pbxFile.js

@@ -165,3 +165,31 @@ exports['path'] = {
         test.done();
     }
 }
+
+exports['settings'] = {
+   'should not be defined by default': function (test) {
+      var sourceFile = new pbxFile('social.framework');
+
+      test.equal(undefined, sourceFile.settings);
+      test.done();
+    },
+  
+    'should be undefined if weak is false or non-boolean': function (test) {
+        var sourceFile1 = new pbxFile('social.framework',
+            { weak: false });
+        var sourceFile2 = new pbxFile('social.framework',
+            { weak: 'bad_value' });
+
+        test.equal(undefined, sourceFile1.settings);
+        test.equal(undefined, sourceFile2.settings);
+        test.done();
+    },
+
+    'should be {ATTRIBUTES:["Weak"]} if weak linking specified': function (test) {
+        var sourceFile = new pbxFile('social.framework',
+            { weak: true });
+
+        test.deepEqual({ATTRIBUTES:["Weak"]}, sourceFile.settings);
+        test.done();
+    }
+}