Merge pull request #4014 from NativeScript/vladimirov/fix-node-warn

rosen-vladimirov · web-flow · commit 74b406dd0260 · 2018-10-11T09:07:01.000+03:00
fix: getNodeWarning always returns warning
diff --git a/lib/common/verify-node-version.ts b/lib/common/verify-node-version.ts
@@ -78,9 +78,13 @@ export function getNodeWarning(): ISystemWarning {
 		}
 	}
 
-	return {
-		message: warningMessage,
-		severity: SystemWarningsSeverity.medium
-	};
+	if (warningMessage) {
+		return {
+			message: warningMessage,
+			severity: SystemWarningsSeverity.medium
+		};
+	}
+
+	return null;
 }
 /* tslint:enable */

Original file line number	Diff line number	Diff line change
`@@ -78,9 +78,13 @@ export function getNodeWarning(): ISystemWarning {`
`78`	`78`	`}`
`79`	`79`	`}`
`80`	`80`
`81`		`- return {`
`82`		`- message: warningMessage,`
`83`		`- severity: SystemWarningsSeverity.medium`
`84`		`- };`
	`81`	`+ if (warningMessage) {`
	`82`	`+ return {`
	`83`	`+ message: warningMessage,`
	`84`	`+ severity: SystemWarningsSeverity.medium`
	`85`	`+ };`
	`86`	`+ }`
	`87`	`+`
	`88`	`+ return null;`
`85`	`89`	`}`
`86`	`90`	`/* tslint:enable */`