Merge pull request #5095 from NativeScript/kddimirov/add-shouldMigrate-trace-log

KristianDD · web-flow · commit 4658457d118e · 2019-10-23T17:02:58.000+03:00
chore: add trace for shouldMigrate caching
diff --git a/lib/controllers/migrate-controller.ts b/lib/controllers/migrate-controller.ts
@@ -163,11 +163,14 @@ Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
 			const cachedResult = await this.getCachedShouldMigrate(projectDir, platform);
 			if (cachedResult !== false) {
 				remainingPlatforms.push(platform);
+			} else {
+				this.$logger.trace(`Got cached result for shouldMigrate for platform: ${platform}`);
 			}
 		}
 
 		if (remainingPlatforms.length > 0) {
 			shouldMigrate = await this._shouldMigrate({ projectDir, platforms: remainingPlatforms, allowInvalidVersions });
+			this.$logger.trace(`Executed shouldMigrate for platforms: ${remainingPlatforms}. Result is: ${shouldMigrate}`);
 
 			if (!shouldMigrate) {
 				for (const remainingPlatform of remainingPlatforms) {

Original file line number	Diff line number	Diff line change
@@ -163,11 +163,14 @@ Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
`163`	`163`	`const cachedResult = await this.getCachedShouldMigrate(projectDir, platform);`
`164`	`164`	`if (cachedResult !== false) {`
`165`	`165`	`remainingPlatforms.push(platform);`
	`166`	`+ } else {`
	`167`	+ this.$logger.trace(`Got cached result for shouldMigrate for platform: ${platform}`);
`166`	`168`	`}`
`167`	`169`	`}`
`168`	`170`
`169`	`171`	`if (remainingPlatforms.length > 0) {`
`170`	`172`	`shouldMigrate = await this._shouldMigrate({ projectDir, platforms: remainingPlatforms, allowInvalidVersions });`
	`173`	+ this.$logger.trace(`Executed shouldMigrate for platforms: ${remainingPlatforms}. Result is: ${shouldMigrate}`);
`171`	`174`
`172`	`175`	`if (!shouldMigrate) {`
`173`	`176`	`for (const remainingPlatform of remainingPlatforms) {`