Merge pull request #23 from NHSDigital/AMB-607-SPIKE-splunk-configure-auth

artronics · web-flow · commit d7b5b9e29915 · 2021-07-01T15:04:46.000+01:00
AMB-751 add default value to SERVICE_BASE_PATH
diff --git a/tests/configuration/environment.py b/tests/configuration/environment.py
@@ -19,6 +19,6 @@ def get_env(variable_name: str) -> str:
     "jwt_private_key_absolute_path": get_env("JWT_PRIVATE_KEY_ABSOLUTE_PATH"),
     "id_token_nhs_login_private_key_absolute_path": get_env("ID_TOKEN_NHS_LOGIN_PRIVATE_KEY_ABSOLUTE_PATH"),
     "id_token_private_key_absolute_path": get_env("ID_TOKEN_PRIVATE_KEY_ABSOLUTE_PATH"),
-    "service_base_path": get_env("SERVICE_BASE_PATH"),
+    "service_base_path": os.getenv("SERVICE_BASE_PATH", "shared-flow-testing"),
     "service_name": os.getenv("SERVICE_NAME", "shared-flow-testing-internal-dev")
 }

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,6 @@ def get_env(variable_name: str) -> str:`
`19`	`19`	`"jwt_private_key_absolute_path": get_env("JWT_PRIVATE_KEY_ABSOLUTE_PATH"),`
`20`	`20`	`"id_token_nhs_login_private_key_absolute_path": get_env("ID_TOKEN_NHS_LOGIN_PRIVATE_KEY_ABSOLUTE_PATH"),`
`21`	`21`	`"id_token_private_key_absolute_path": get_env("ID_TOKEN_PRIVATE_KEY_ABSOLUTE_PATH"),`
`22`		`- "service_base_path": get_env("SERVICE_BASE_PATH"),`
	`22`	`+ "service_base_path": os.getenv("SERVICE_BASE_PATH", "shared-flow-testing"),`
`23`	`23`	`"service_name": os.getenv("SERVICE_NAME", "shared-flow-testing-internal-dev")`
`24`	`24`	`}`