Skip to content

Commit a2f33e9

Browse files
[PRM-697] Logging version of SSM parameter
1 parent 5878c00 commit a2f33e9

File tree

4 files changed

+9
-11
lines changed

4 files changed

+9
-11
lines changed

services/re-registration-service/src/integration/java/uk/nhs/prm/repo/re_registration/ehr_repo/EhrRepoServiceIntegrationTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ public class EhrRepoServiceIntegrationTest {
3636
public static final String CONVERSATION_ID1 = "2431d4ff-f760-4ab9-8cd8-a3fc47846762";
3737
public static final String CONVERSATION_ID2 = "c184cc19-86e9-4a95-b5b5-2f156900bb3c";
3838

39-
4039
@BeforeEach
4140
public void setUp() {
4241
stubEhrRepo = initializeWebServer();

services/re-registration-service/src/main/java/uk/nhs/prm/repo/re_registration/service/SsmService.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import org.springframework.stereotype.Service;
66
import software.amazon.awssdk.services.ssm.SsmClient;
77
import software.amazon.awssdk.services.ssm.model.GetParameterRequest;
8+
import software.amazon.awssdk.services.ssm.model.Parameter;
89

910
@Slf4j
1011
@Service
@@ -25,12 +26,10 @@ public String getValueForParameter(String parameterName) {
2526
.withDecryption(true)
2627
.build();
2728

28-
String parameterValue = ssmClient.getParameter(parameterRequest)
29-
.parameter()
30-
.value();
29+
Parameter parameter = ssmClient.getParameter(parameterRequest).parameter();
3130

32-
log.info("Value for SSM parameter {} retrieved successfully", parameterName);
31+
log.info("Value for SSM parameter {} retrieved successfully. Parameter version is: {}", parameterName, parameter.version());
3332

34-
return parameterValue;
33+
return parameter.value();
3534
}
3635
}

services/suspension-service/src/integration/java/uk/nhs/prm/repo/suspension/service/repo/in/MOFUpdateToRepoIntegrationTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
@ContextConfiguration(classes = LocalStackAwsConfig.class)
3434
@DirtiesContext
3535
public class MOFUpdateToRepoIntegrationTest {
36+
private static final String AUTHORIZATION_HEADER = "Basic c3VzcGVuc2lvbi1zZXJ2aWNlOnRlc3Q=";
3637

3738
@Autowired
3839
private SqsClient sqs;

services/suspension-service/src/main/java/uk/nhs/prm/repo/suspension/service/service/SsmService.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import org.springframework.stereotype.Service;
66
import software.amazon.awssdk.services.ssm.SsmClient;
77
import software.amazon.awssdk.services.ssm.model.GetParameterRequest;
8+
import software.amazon.awssdk.services.ssm.model.Parameter;
89

910
@Slf4j
1011
@Service
@@ -25,12 +26,10 @@ public String getValueForParameter(String parameterName) {
2526
.withDecryption(true)
2627
.build();
2728

28-
String parameterValue = ssmClient.getParameter(parameterRequest)
29-
.parameter()
30-
.value();
29+
Parameter parameter = ssmClient.getParameter(parameterRequest).parameter();
3130

32-
log.info("Value for SSM parameter {} retrieved successfully", parameterName);
31+
log.info("Value for SSM parameter {} retrieved successfully. Parameter version is: {}", parameterName, parameter.version());
3332

34-
return parameterValue;
33+
return parameter.value();
3534
}
3635
}

0 commit comments

Comments
 (0)