remove comments

Author: josielsouzanordcloud

infrastructure/modules/managed-identity/tests/managed_identity_test.go

@@ -11,22 +11,15 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-// setupTestModule copies the module to a temp directory and injects a provider file.
-// This avoids race conditions when running tests in parallel and keeps the source clean.
 func setupTestModule(t *testing.T, vars map[string]any) string {
 	moduleDir := "../"
 
-	// Copy all .tf files to temp directory
 	tempDir, err := files.CopyTerraformFolderToTemp(moduleDir, t.Name())
 	if err != nil {
-		// Fallback: manually copy files
 		tempDir = t.TempDir()
 		copyTerraformFiles(t, moduleDir, tempDir)
 	}
 
-	// Inject provider configuration
-	// Note: Variable validations are evaluated BEFORE provider authentication,
-	// so these tests work offline. The provider config is only needed for syntax.
 	// We only need to inject the provider block, as required_providers is now in versions.tf
 	providerContent := "provider \"azurerm\" {\nfeatures {}\n}\n"
 	providerPath := filepath.Join(tempDir, "provider_test.tf")
@@ -35,13 +28,11 @@ func setupTestModule(t *testing.T, vars map[string]any) string {
 		t.Fatalf("failed to write provider file: %v", err)
 	}
 
-	// Write variables to a .tfvars file (terraform validate doesn't accept -var flags)
 	writeVarsFile(t, tempDir, vars)
 
 	return tempDir
 }
 
-// writeVarsFile writes variables to a terraform.tfvars file
 func writeVarsFile(t *testing.T, dir string, vars map[string]any) {
 	var content string
 	for k, v := range vars {
@@ -68,18 +59,14 @@ func writeVarsFile(t *testing.T, dir string, vars map[string]any) {
 	}
 }
 
-// copyTerraformFiles copies .tf files from src to dst
 func copyTerraformFiles(t *testing.T, src, dst string) {
 	entries, err := os.ReadDir(src)
 	if err != nil {
 		t.Fatalf("failed to read source directory: %v", err)
 	}
 
 	for _, entry := range entries {
-		if entry.IsDir() {
-			continue
-		}
-		if filepath.Ext(entry.Name()) != ".tf" {
+		if entry.IsDir() || filepath.Ext(entry.Name()) != ".tf" {
 			continue
 		}
 
@@ -98,7 +85,6 @@ func copyTerraformFiles(t *testing.T, src, dst string) {
 	}
 }
 
-// TestManagedIdentity_ValidInputs verifies the module accepts valid configurations.
 func TestManagedIdentity_ValidInputs(t *testing.T) {
 	t.Parallel()
 
@@ -114,7 +100,7 @@ func TestManagedIdentity_ValidInputs(t *testing.T) {
 		},
 		{
 			name:    "minimum_length_name",
-			uaiName: "abc", // Exactly 3 characters (minimum)
+			uaiName: "abc",
 			tags:    nil,
 		},
 		{
@@ -152,9 +138,7 @@ func TestManagedIdentity_ValidInputs(t *testing.T) {
 	}
 }
 
-// TestManagedIdentity_InvalidName verifies the module rejects invalid identity names.
-// Note: Variable validation rules are only evaluated during 'plan' or 'apply', not 'validate'.
-// Therefore, we use InitAndPlanE to trigger the validation checks.
+// Variable validation rules are only evaluated during 'plan' or 'apply', not 'validate'.
 func TestManagedIdentity_InvalidName(t *testing.T) {
 	t.Parallel()
 
@@ -166,12 +150,12 @@ func TestManagedIdentity_InvalidName(t *testing.T) {
 		{
 			name:        "too_short_one_char",
 			uaiName:     "a",
-			description: "single character should be rejected (minimum is 3)",
+			description: "single character should be rejected",
 		},
 		{
 			name:        "too_short_two_chars",
 			uaiName:     "ab",
-			description: "two characters should be rejected (minimum is 3)",
+			description: "two characters should be rejected",
 		},
 		{
 			name:        "starts_with_hyphen",
@@ -206,7 +190,6 @@ func TestManagedIdentity_InvalidName(t *testing.T) {
 				NoColor:      true,
 			}
 
-			// Use InitAndPlanE because variable validations are only evaluated during plan/apply
 			_, err := terraform.InitAndPlanE(t, terraformOptions)
 
 			assert.Error(t, err, tc.description)