ninja-xtask: show stdout and exit status for failed commands

[MusicalNinjaDad]

No description provided.

[sourcery-ai]

Hey - I've left some high level feedback:

• When building the formatted error string, consider including the full command (or at least its arguments) alongside cmd.name so failures are easier to trace back to the exact invocation.
• In fail_output, asserting on multiple substrings of the formatted output makes this test somewhat brittle; you could instead assert on a smaller number of higher-level invariants (for example, presence of labeled stdout/stderr sections and exit status) to reduce coupling to the exact formatting.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- When building the formatted error string, consider including the full command (or at least its arguments) alongside `cmd.name` so failures are easier to trace back to the exact invocation.
- In `fail_output`, asserting on multiple substrings of the formatted output makes this test somewhat brittle; you could instead assert on a smaller number of higher-level invariants (for example, presence of labeled stdout/stderr sections and exit status) to reduce coupling to the exact formatting.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}