[+] UgcGenerator Slide、Air Hold、Air Slide的正确实现

Author: Starrah

generator/chu/C2sGenerator.cs

@@ -67,6 +67,13 @@ private static string Serialize(ChuChart chart, List<Alert> alerts)
         return sb.ToString();
     }
 
+    private static List<string> allowedAirColors = ["DEF"]; // TODO 搞清楚UGC里的'I'颜色，在C2S里，对应的字符串是什么
+    private static string AirColorTag(ChuNote n)
+    {
+        if (allowedAirColors.Contains(n.Tag)) return n.Tag;
+        else return "DEF";
+    }
+
     private static string? FormatNote(ChuNote n, int tpm, List<Alert> alerts)
     {
         var (m, o) = Utils.BarAndTick(n.Time, tpm);
@@ -79,13 +86,8 @@ private static string Serialize(ChuChart chart, List<Alert> alerts)
             "SLD" or "SLC" or "SXD" or "SXC" => $"{n.Type}\t{m}\t{o}\t{n.Cell}\t{n.Width}\t{durTicks}\t{n.EndCell}\t{n.EndWidth}",
             "FLK" => $"FLK\t{m}\t{o}\t{n.Cell}\t{n.Width}\t{n.Tag}",
             "AIR" or "AUR" or "AUL" or "ADW" or "ADR" or "ADL" =>
-                string.IsNullOrEmpty(n.Tag)
-                    ? $"{n.Type}\t{m}\t{o}\t{n.Cell}\t{n.Width}\t{n.TargetNote}"
-                    : $"{n.Type}\t{m}\t{o}\t{n.Cell}\t{n.Width}\t{n.TargetNote}\t{n.Tag}",
-            "AHD" or "AHX" =>
-                string.IsNullOrEmpty(n.Tag)
-                    ? $"{n.Type}\t{m}\t{o}\t{n.Cell}\t{n.Width}\t{n.TargetNote}\t{durTicks}"
-                    : $"{n.Type}\t{m}\t{o}\t{n.Cell}\t{n.Width}\t{n.TargetNote}\t{durTicks}\t{n.Tag}",
+                    $"{n.Type}\t{m}\t{o}\t{n.Cell}\t{n.Width}\t{n.TargetNote}\t{AirColorTag(n)}",
+            "AHD" or "AHX" => $"{n.Type}\t{m}\t{o}\t{n.Cell}\t{n.Width}\t{n.TargetNote}\t{durTicks}\t{AirColorTag(n)}",
             "ASD" or "ASC" => FormatAsdAsc(n, m, o, durTicks),
             "ALD" => FormatAld(n, m, o),
             "MNE" => $"MNE\t{m}\t{o}\t{n.Cell}\t{n.Width}",
@@ -101,9 +103,9 @@ private static string Serialize(ChuChart chart, List<Alert> alerts)
 
     private static string FormatAsdAsc(ChuNote n, int m, int o, int durTicks)
     {
-        var e0 = n.ExtraData.Count > 0 ? n.ExtraData[0] : 0;
-        var e1 = n.ExtraData.Count > 1 ? n.ExtraData[1] : 0;
-        return $"{n.Type}\t{m}\t{o}\t{n.Cell}\t{n.Width}\t{n.TargetNote}\t{e0}\t{durTicks}\t{n.EndCell}\t{n.EndWidth}\t{e1}\t{n.Tag}";
+        var e0 = n.ExtraData.Count > 0 ? n.ExtraData[0] : 5;
+        var e1 = n.ExtraData.Count > 1 ? n.ExtraData[1] : 5;
+        return $"{n.Type}\t{m}\t{o}\t{n.Cell}\t{n.Width}\t{n.TargetNote}\t{e0}\t{durTicks}\t{n.EndCell}\t{n.EndWidth}\t{e1}\t{AirColorTag(n)}";
     }
 
     private static string FormatAld(ChuNote n, int m, int o)

generator/chu/UgcGenerator.cs

@@ -11,16 +11,16 @@ public class UgcGenerator : IGenerator<ChuChart>
     public (string, List<Alert>) Generate(ChuChart chart)
     {
         var alerts = new List<Alert>();
-        var text = Serialize(chart);
+        var text = Serialize(chart, alerts);
         return (text, alerts);
     }
 
-    private static string Serialize(ChuChart ugc)
+    private static string Serialize(ChuChart ugc, List<Alert> alerts)
     {
         ugc.Sort();
 
         var sb = new StringBuilder();
-        sb.AppendLine("@VER\t6");
+        sb.AppendLine("@VER\t8");
         if (!string.IsNullOrEmpty(ugc.Title)) sb.AppendLine($"@TITLE\t{ugc.Title}");
         if (!string.IsNullOrEmpty(ugc.Artist)) sb.AppendLine($"@ARTIST\t{ugc.Artist}");
         if (!string.IsNullOrEmpty(ugc.Designer)) sb.AppendLine($"@DESIGN\t{ugc.Designer}");
@@ -51,24 +51,123 @@ private static string Serialize(ChuChart ugc)
         sb.AppendLine("@ENDHEAD");
         sb.AppendLine();
 
+        // UGC Slide / AIR-SLIDE (v8):
+        // - Chains (ChuNote.Previous) serialize as ONE parent line + follower lines (#OffsetTick from parent time).
+        // - Ground slide: parent `s`, followers `>s` / `>c` + end cell/width.
+        // - Air slide: parent `S` + cell/width + hh (base-36 ×2, C2S/UGC height units) + N/I; followers `>s`/`>c` + xw + hh.
+        // - First segment may attach to TAP/HLD via Previous; only skip emit when Previous is another segment of the same chain.
+        var slideChains = BuildSlideChains(ugc.Notes);
+
         foreach (var n in ugc.Notes)
         {
+            if (IsSlideChainNote(n.Type) && n.Previous != null && IsSlideChainNote(n.Previous.Type))
+                continue; // 是Slide且不是第一段Slide，则应当已经被处理过了，直接跳过
+
             var (m, o) = Utils.BarAndTick(n.Time, RSL);
-            sb.Append($"#{m}'{o}:{UCode(n, RSL)}");
+            var ucode = UCode(n);
+            if (ucode == "")
+            {
+                alerts.Add(new Alert(Alert.LEVEL.Warning, $"UGC Generator遇到了不支持的音符类型: {n.Type}", n.Time, (double)ugc.ToSecond(n.Time)));
+                continue;
+            }
+            sb.Append($"#{m}'{o}:{ucode}");
             sb.AppendLine();
+
+            if (IsSlideChainNote(n.Type))
+            {
+                if (slideChains.TryGetValue(n, out var segments))
+                {
+                    var isAir = IsAirSlideType(n.Type);
+                    foreach (var seg in segments)
+                    {
+                        var endTicks = Utils.Tick(seg.EndTime - n.Time, RSL);
+                        if (endTicks <= 0) continue;
+                        if (isAir)
+                            sb.AppendLine($"#{endTicks}>{SlideFollowerMarker(seg.Type)}{IntToHex(seg.EndCell)}{IntToHex(seg.EndWidth)}{EncodeUgcAirHeight2(AirSlideFollowerHeight(seg))}");
+                        else
+                            sb.AppendLine($"#{endTicks}>{SlideFollowerMarker(seg.Type)}{IntToHex(seg.EndCell)}{IntToHex(seg.EndWidth)}");
+                    }
+                }
+                continue;
+            }
+
             var durTicks = Utils.Tick(n.Duration, RSL);
-            if (n.Type == "HLD" && durTicks > 0)
+            if (n.Type is "HLD" or "HXD" && durTicks > 0)
                 sb.AppendLine($"#{durTicks}>s");
-            else if (n.Type == "SLD" && durTicks > 0)
-                sb.AppendLine($"#{durTicks}>s{Hx(n.EndCell)}{Hw(n.EndWidth)}");
+            else if (n.Type is "AHD" or "AHX" && durTicks > 0)
+            {
+                var marker = (n.Type == "AHX") ? 'c' : 's';
+                sb.AppendLine($"#{durTicks}>{marker}");
+            }
         }
         return sb.ToString();
     }
 
-    private static string UCode(ChuNote n, int tpm)
+    private static Dictionary<ChuNote, List<ChuNote>> BuildSlideChains(List<ChuNote> notes)
+    {
+        var chains = new Dictionary<ChuNote, List<ChuNote>>();
+        foreach (var n in notes)
+        {
+            if (!IsSlideChainNote(n.Type)) continue;
+            var head = GetSlideHead(n);
+            if (!chains.TryGetValue(head, out var list))
+                chains[head] = list = [];
+            list.Add(n);
+        }
+
+        // Order segments by their end time so follower ticks are increasing.
+        foreach (var (_, segs) in chains)
+        {
+            segs.Sort((a, b) =>
+            {
+                var t = a.EndTime.CompareTo(b.EndTime);
+                if (t != 0) return t;
+                // stable-ish tie-breakers
+                t = a.Time.CompareTo(b.Time);
+                if (t != 0) return t;
+                t = string.CompareOrdinal(a.Type, b.Type);
+                if (t != 0) return t;
+                return 0;
+            });
+        }
+
+        // For a valid chain, follower ticks should be strictly increasing; if the chart has
+        // degenerate segments, later code simply skips non-positive offsets.
+        return chains;
+    }
+
+    private static ChuNote GetSlideHead(ChuNote n)
+    {
+        var cur = n;
+        while (cur.Previous != null && IsSlideChainNote(cur.Previous.Type))
+            cur = cur.Previous;
+        return cur;
+    }
+
+    private static bool IsSlideType(string t) => t is "SLD" or "SLC" or "SXD" or "SXC";
+    private static bool IsAirSlideType(string t) => t is "ASD" or "ASC";
+    private static bool IsSlideChainNote(string t) => IsSlideType(t) || IsAirSlideType(t);
+    private static char SlideFollowerMarker(string t) => t is "SLC" or "SXC" or "ASC" ? 'c' : 's';
+
+    /// <summary> C2S col.6 / follower height: integer stored as two base-36 digits (Umiguri v8 AIR-SLIDE). </summary>
+    private static string EncodeUgcAirHeight2(int value)
+    {
+        var v = Math.Clamp(value * 10, 0, 35 * 36 + 35);
+        var hi = v / 36;
+        var lo = v % 36;
+        return $"{IntToHex(hi)}{IntToHex(lo)}";
+    }
+
+    private static int AirSlideParentStartHeight(ChuNote head) => 8; // TODO 现在暂时写死，之后应该改成从ExtraData等地方读取
+    private static int AirSlideFollowerHeight(ChuNote seg) => 8; // TODO 现在暂时写死，之后应该改成从ExtraData等地方读取
+
+    private static Dictionary<string, string> AirDirections = new()
     {
-        string c = Hx(n.Cell), w = Hw(n.Width);
-        var durTicks = Utils.Tick(n.Duration, tpm);
+        ["AIR"] = "UC", ["AUR"] = "UR", ["AUL"] = "UL", ["ADW"] = "DC", ["ADR"] = "DR", ["ADL"] = "DL",
+    };
+    private static string UCode(ChuNote n)
+    {
+        string c = IntToHex(n.Cell), w = IntToHex(n.Width);
         var targetNote = string.IsNullOrEmpty(n.TargetNote) ? "N" : n.TargetNote;
         return n.Type switch
         {
@@ -79,17 +178,21 @@ private static string UCode(ChuNote n, int tpm)
             "SLC" or "SXC" => $"s{c}{w}",
             "FLK" => $"f{c}{w}A",
             "MNE" => $"d{c}{w}",
-            "AIR" => $"a{c}{w}UC{targetNote}",
-            "AUR" => $"a{c}{w}UR{targetNote}",
-            "AUL" => $"a{c}{w}UL{targetNote}",
-            "AHD" or "AHX" => $"a{c}{w}HD{targetNote}_{durTicks}",
-            "ADW" => $"a{c}{w}DC{targetNote}",
-            "ADR" => $"a{c}{w}DR{targetNote}",
-            "ADL" => $"a{c}{w}DL{targetNote}",
-            _ => $"t{c}{w}"
+            // AIR-SLIDE (v8): #BarTick:S x w hh c
+            "ASD" or "ASC" => $"S{c}{w}{EncodeUgcAirHeight2(AirSlideParentStartHeight(n))}{AirHoldColorSuffix(n)}",
+            "AIR" or "AUR" or "AUL" or "ADW" or "ADR" or "ADL" => $"a{c}{w}{AirDirections[n.Type]}{targetNote}{AirHoldColorSuffix(n)}",
+            // AIR-HOLD (v8): #BarTick:H x w c + 子行 #OffsetTick:s / :c（见 Umiguri Chart v8 doc）
+            "AHD" or "AHX" => $"H{c}{w}{AirHoldColorSuffix(n)}",
+            _ => ""
         };
     }
 
-    private static string Hx(int v) => "0123456789ABCDEF"[Math.Clamp(v, 0, 15)].ToString();
-    private static string Hw(int v) => "123456789ABCDEFG"[Math.Clamp(v - 1, 0, 15)].ToString();
+    private static string IntToHex(int v) => "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ"[Math.Clamp(v, 0, 35)].ToString();
+
+    private static readonly Dictionary<string, string> AirColor = new()
+    {
+        ["DEF"] = "N",
+        ["I"] = "I", // TODO 搞清楚UGC里的'I'颜色，在C2S里，对应的字符串是什么
+    };
+    private static string AirHoldColorSuffix(ChuNote n) => AirColor.GetValueOrDefault(n.Tag, "N");
 }

parser/chu/UgcParser.cs

@@ -30,6 +30,12 @@ public class UgcParser: BaseChuParser
         ["D"] = "DW",
         ["C"] = "CE",
     };
+    
+    private static readonly Dictionary<string, string> AirColor = new()
+    {
+        ["N"] = "DEF",
+        ["I"] = "I", // TODO 搞清楚UGC里的'I'颜色，在C2S里，对应的字符串是什么
+    };
 
     public override (ChuChart, List<Alert>) Parse(string text)
     {
@@ -351,8 +357,8 @@ private static int ParseHoldNote(bool isAirHold, string[] lines, int idx, string
 
         if (isAirHold)
         {
-            // 解析颜色数据。目前只解析、不使用。
-            _ = code.Last(); // var colorChar 颜色标记 N/I
+            var colorChar = code.Last(); // 颜色标记 N/I
+            note.Tag = AirColor[colorChar.ToString()];
         }
 
         bool foundFirst = false;
@@ -384,11 +390,13 @@ private static int ParseSlideNote(bool isAirSlide, string[] lines, int idx, stri
         previousNote.EndCell = previousNote.Cell;
         previousNote.EndWidth = previousNote.Width;
 
+        string colorTag = "";
         if (isAirSlide)
         {
-            // 解析高度和颜色数据。目前只解析、不使用。
+            var colorChar = code.Last(); // 颜色标记 N/I
+            colorTag = AirColor[colorChar.ToString()];
+            // 解析高度数据。目前只解析、不使用。
             TryParseUgcBase36Int2(code.AsSpan(3, code.Length - 4), out _); // out var startHeight 起始的高度值
-            _ = code.Last(); // var colorChar 颜色标记 N/I
         }
 
         bool foundFirst = false;
@@ -412,6 +420,8 @@ private static int ParseSlideNote(bool isAirSlide, string[] lines, int idx, stri
                 EndCell = endCell, EndWidth = endWidth,
                 Previous = foundFirst ? previousNote : null,
             };
+            if (isAirSlide) note.Tag = colorTag;
+            
             chart.Notes.Add(note);
             previousNote = note;
             idx++;

tests/chu/ChuTests.cs

@@ -55,6 +55,7 @@ private static string SnapshotNote(ChuNote note)
         {
             Rational r => r.CanonicalForm.ToString(),
             List<int> list => string.Join(",", list),
+            string s => s == "DEF" ? "" : s,
             null => "",
             _ => v.ToString() ?? "",
         };