[R] 进一步重构测试脚本，减少冗余代码

Author: Starrah

tests/MA2转Simai测试.cs

@@ -7,7 +7,6 @@
 using MuConvert.parser;
 using Rationals;
 using Xunit.Abstractions;
-using static MuConvert.Tests.TestUtils;
 
 namespace MuConvert.Tests;
 
@@ -21,25 +20,10 @@ public class MA2转Simai测试
 
     public MA2转Simai测试(ITestOutputHelper output) => _output = output;
 
-    public static IEnumerable<object[]> AllLevels(string dataDir)
-    {
-        var repoRoot = FindRepoRoot();
-        var testsetRoot = Path.Combine(repoRoot.FullName, "tests", "testset", dataDir);
-        if (!Directory.Exists(testsetRoot))
-            throw new DirectoryNotFoundException($"Testset root not found: {testsetRoot}");
-
-        foreach (var maidataPath in Directory.EnumerateFiles(testsetRoot, "maidata.txt", SearchOption.AllDirectories))
-        {
-            var maidataTxt = File.ReadAllText(maidataPath, Encoding.UTF8);
-            var maidata = new Maidata(maidataTxt);
-            foreach (var id in maidata.Levels.Keys.OrderBy(k => k))
-                // if (maidataPath.Contains("系ぎて") && id == 3)
-                yield return [new TestInput(maidataPath, id)];
-        }
-    }
-
+    public static IEnumerable<object[]> GetTestInputs(string dataDir) => TestUtils.GetTestInputs(dataDir);
+    
     [Theory]
-    [MemberData(nameof(AllLevels), "官谱")]
+    [MemberData(nameof(GetTestInputs), "官谱")]
     public void 官谱转Simai测试(TestInput c) => TestChart(c);
 
     private void TestChart(TestInput c)

tests/Simai转MA2测试.cs

@@ -4,7 +4,6 @@
 using MuConvert.parser;
 using MuConvert.utils;
 using Xunit.Abstractions;
-using static MuConvert.Tests.TestUtils;
 
 namespace MuConvert.Tests;
 
@@ -15,28 +14,11 @@ public class Simai转MA2测试
 
     public Simai转MA2测试(ITestOutputHelper output) => _output = output;
 
-    /// <summary>
-    /// 每个元素对应一张谱面：一条 Theory 用例只跑一个 chart。
-    /// </summary>
-    public static IEnumerable<object[]> AllCharts(string dataDir)
-    {
-        // TODO 再多找一些自制谱加进来吧
-        var repoRoot = FindRepoRoot();
-        var testsetRoot = Path.Combine(repoRoot.FullName, "tests", "testset", dataDir);
-        if (!Directory.Exists(testsetRoot))
-            throw new DirectoryNotFoundException($"Testset root not found: {testsetRoot}");
-
-        foreach (var maidataPath in Directory.EnumerateFiles(testsetRoot, "maidata.txt", SearchOption.AllDirectories))
-        {
-            var maidataTxt = File.ReadAllText(maidataPath, Encoding.UTF8);
-            var maidata = new Maidata(maidataTxt);
-            foreach (var id in maidata.Levels.Keys.OrderBy(k => k))
-                yield return [new TestInput(maidataPath, id)];
-        }
-    }
+    public static IEnumerable<object[]> GetTestInputs(string dataDir) => TestUtils.GetTestInputs(dataDir);
 
+    // TODO 再多找一些自制谱加进来吧
     [Theory]
-    [MemberData(nameof(AllCharts), "自制谱")]
+    [MemberData(nameof(GetTestInputs), "自制谱")]
     public void 自制谱转MA2测试(TestInput c) => TestChart(c);
 
     private void TestChart(TestInput input)

tests/TestUtils.cs

@@ -40,6 +40,26 @@ public static Chart LoadOneChart(out List<Alert> alerts)
         Assert.DoesNotContain(alerts, a => a.Level >= Alert.LEVEL.Error);
         return chart;
     }
+    
+    public static IEnumerable<object[]> GetTestInputs(string dataDir, int? lv = null, string? title = null)
+    {
+        var repoRoot = FindRepoRoot();
+        var testsetRoot = Path.Combine(repoRoot.FullName, "tests", "testset", dataDir);
+        if (!Directory.Exists(testsetRoot))
+            throw new DirectoryNotFoundException($"Testset root not found: {testsetRoot}");
+
+        foreach (var maidataPath in Directory.EnumerateFiles(testsetRoot, "maidata.txt", SearchOption.AllDirectories))
+        {
+            var maidataTxt = File.ReadAllText(maidataPath, Encoding.UTF8);
+            var maidata = new Maidata(maidataTxt);
+            foreach (var id in maidata.Levels.Keys.OrderBy(k => k))
+            {
+                // 如果指定了lv或title、但与要求不符，则不返回
+                if ((lv != null && id != lv) || (title != null && !maidataPath.Contains("title"))) continue;
+                yield return [new TestInput(maidataPath, id)];
+            }
+        }
+    }
 }
 
 public record TestInput(string Maidata, int LevelId)