SFunction inefficient implementation

[telephon]

SFunction implements value like this :

   value{ arg ...args;
      ^function.inEnvir( envir ).value( *args );
   }

   valueArray{ arg ...args;
        ^function.inEnvir( envir ).value( *(args.unbubble) );
    }

This is extremely complicated and inefficient, the following should be enough:

 value{ arg ...args;
      ^envir.use { function.valueArray(args) }
   }

also valueArray should take an array as argument:

   valueArray{ arg args; // not ... args
         ^envir.use { function.valueArray(args) }
    }

[sensestage]

It has been a while since I made the implementation, but I seem to
recall that envir.use somehow did not work correctly, or the envir was
passed as the first argument or something.

Did you test with the changed implementation?

sincerely,
Marije

On 04-04-14 12:21, Julian Rohrhuber wrote:

SFunction implements |value| like this :

| value{ arg ...args;
^function.inEnvir( envir ).value( *args );
}

valueArray{ arg ...args;
^function.inEnvir( envir ).value( *(args.unbubble) );
}
|

This is extremely complicated and inefficient, the following should be
enough:

| value{ arg ...args;
^envir.use { function.valueArray(args) }
}

|
|

also valueArray should take an array as argument:

| valueArray{ arg args; // not ... args
^envir.use { function.valueArray(args) }
}
|

—
Reply to this email directly or view it on GitHub
#1.

[telephon]

No, I haven't tested it. But I am pretty sure just from reading. Maybe the other mistake (...args in valueArray) caused the problem?

also value( *(args.unbubble) ) is exactly the same as valueArray(args)