Skip to content

Commit dcbbf32

Browse files
author
Argon
committed
Approvals Fixed
1 parent 0cdec4e commit dcbbf32

11 files changed

+22
-11
lines changed

Infrastructure/Sessions/00010203-0405-0607-0809-0a0b0c0d0e0f

Whitespace-only changes.

Infrastructure/SettingsManager.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,3 +108,6 @@ def get_dojo_session_id(self):
108108

109109
def get_dojo_topic_root(self):
110110
return self.code_dojo.get("topic root", "MobTimer")
111+
112+
def get_general_enable_unobtrusive_mode_bouncing_screen(self):
113+
return self.general_settings_.getboolean("enable unobtrusive mode bouncing screen", False)

MobTimer.cfg

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ use logo image = False
2323
logo image name = company-logo.png
2424
auto theme logo = False
2525
enable unobtrusive mode = False
26+
enable unobtrusive mode bouncing screen = True
2627

2728
[TIMER SETTINGS]
2829
minutes = 5

tests/Infrastructure/CountdownManager/TestsCountdownManager.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,14 @@
33
import unittest
44

55
from approvaltests import Approvals
6-
from approvaltests.TextDiffReporter import TextDiffReporter
6+
from approvaltests.GenericDiffReporterFactory import GenericDiffReporterFactory
77

88
from Infrastructure.CountdownManager import CountdownManager
99

1010

1111
class TestsCountdownManager(unittest.TestCase):
12+
def setUp(self):
13+
self.reporter = GenericDiffReporterFactory().get_first_working()
1214

1315
def test_set_countdown_timer(self):
1416
countdown_manager = CountdownManager(None)
@@ -37,7 +39,7 @@ def time_change_callback(days, minutes, seconds):
3739
countdown_manager.set_countdown_duration(853, 32)
3840
countdown_manager.set_countdown_duration(3, 62)
3941

40-
Approvals.verify(result["result"], TextDiffReporter())
42+
Approvals.verify(result["result"], self.reporter)
4143

4244

4345
if __name__ == '__main__':

tests/Infrastructure/CountdownManager/tests.Infrastructure.CountdownManager.TestsCountdownManager.test_subscribe_to_time_changes.approved.txt renamed to tests/Infrastructure/CountdownManager/TestsCountdownManager.test_subscribe_to_time_changes.approved.txt

File renamed without changes.

tests/Infrastructure/MobberManager/TestsMobberManager.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@
22
import random
33
import unittest
44
from approvaltests import Approvals
5-
from approvaltests.TextDiffReporter import TextDiffReporter
5+
from approvaltests.GenericDiffReporterFactory import GenericDiffReporterFactory
66
from Infrastructure.MobberManager import MobberManager
77

8-
os.environ["APPROVALS_TEXT_DIFF_TOOL"] = "C:\\Program Files\\TortoiseSVN\\bin\\TortoiseMerge.exe"
9-
108

119
class TestsMobberManager(unittest.TestCase):
10+
def setUp(self):
11+
self.reporter = GenericDiffReporterFactory().get_first_working()
12+
1213
def test_empty_mobber_manager_has_no_items(self):
1314
mobber_manager = MobberManager()
1415
self.assertEqual(mobber_manager.mobber_count(), 0)
@@ -147,7 +148,7 @@ def time_change_callback(mobber_list, driver_index, navigator_index):
147148
mobber_manager.remove_mobber(0)
148149
mobber_manager.remove_mobber(0)
149150

150-
Approvals.verify(result["result"], TextDiffReporter())
151+
Approvals.verify(result["result"], self.reporter)
151152

152153
def test_subscribe_to_mobber_list_changes_random(self):
153154
random.seed(0)
@@ -192,7 +193,7 @@ def time_change_callback(mobber_list, driver_index, navigator_index):
192193
mobber_manager.remove_mobber(0)
193194
mobber_manager.remove_mobber(0)
194195

195-
Approvals.verify(result["result"], TextDiffReporter())
196+
Approvals.verify(result["result"], self.reporter)
196197

197198
def test_navigator1_driver0_index(self):
198199
mobber_manager = MobberManager()

tests/Infrastructure/MobberManager/tests.Infrastructure.MobberManager.TestsMobberManager.test_subscribe_to_mobber_list_changes.approved.txt renamed to tests/Infrastructure/MobberManager/TestsMobberManager.test_subscribe_to_mobber_list_changes.approved.txt

File renamed without changes.

tests/Infrastructure/MobberManager/tests.Infrastructure.MobberManager.TestsMobberManager.test_subscribe_to_mobber_list_changes_random.approved.txt renamed to tests/Infrastructure/MobberManager/TestsMobberManager.test_subscribe_to_mobber_list_changes_random.approved.txt

File renamed without changes.

tests/Infrastructure/TimeOptionsManager/TestsTimeOptionsManager.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,15 @@
22
import unittest
33

44
from approvaltests import Approvals
5-
from approvaltests.TextDiffReporter import TextDiffReporter
5+
from approvaltests.GenericDiffReporterFactory import GenericDiffReporterFactory
66

77
from Infrastructure.TimeSettingsManager import TimeSettingsManager
88

99

1010
class TestsTimeOptionsManager(unittest.TestCase):
11+
def setUp(self):
12+
self.reporter = GenericDiffReporterFactory().get_first_working()
13+
1114
def test_default_time_10_minutes(self):
1215
time_options_manager = TimeSettingsManager()
1316
result = time_options_manager.get_time_string()
@@ -93,7 +96,7 @@ def time_change_callback(time, minutes, seconds,origin_station_name):
9396
time_options_manager.increment_minutes()
9497
time_options_manager.set_countdown_time(3, 14)
9598

96-
Approvals.verify(result["result"], TextDiffReporter())
99+
Approvals.verify(result["result"], self.reporter)
97100

98101
if __name__ == '__main__':
99102
os.environ["APPROVALS_TEXT_DIFF_TOOL"] = "meld"

tests/Infrastructure/TimeOptionsManager/tests.Infrastructure.TimeOptionsManager.TestsTimeOptionsManager.test_subscribe_to_time_changes_complex.approved.txt renamed to tests/Infrastructure/TimeOptionsManager/TestsTimeOptionsManager.test_subscribe_to_time_changes_complex.approved.txt

File renamed without changes.

0 commit comments

Comments
 (0)