t - Added tests for EventLoggingManager and updated tests for TipsManager

Author: Pipeline

Infrastructure/EventLoggingManager.py

@@ -4,6 +4,10 @@
 class EventLoggingManager:
 
     def __init__(self, file_utility):
-        file_path = file_utility.get_root_path() + "\\MobTimerEvents.log"
-        if not file_utility.file_exists(file_path):
-            file_utility.create_file(file_path)
+        self.file_path = file_utility.get_root_path() + "\\MobTimerEvents.log"
+        self.file_utility = file_utility
+        if not self.file_utility.file_exists(self.file_path):
+            self.file_utility.create_file(self.file_path)
+
+    def log(self, data):
+        self.file_utility.append(self.file_path, '\n' + data)

Infrastructure/FileUtilities.py

@@ -22,3 +22,8 @@ def file_exists(self, file_path):
     def create_file(self, file_path):
         f = open(file_path, "w")
         f.close()
+
+    def append(self, file_path, data):
+        f = open(file_path, "w+")
+        f.write(data)
+        f.close()

Infrastructure/TipsManager.py

@@ -12,7 +12,11 @@ def __init__(self, seed=None, root_directory=sys.argv[0]):
             random.seed(seed)
 
     def go_up_dir(self, root_directory):
-        return "/".join(root_directory.split('\\')[:-1])
+        if '\\' in root_directory:
+            return "/".join(root_directory.split('\\')[:-1])
+        else:
+            return "/".join(root_directory.split('/')[:-1])
+
 
     def get_random_tip(self):
         tips_folder = self.root_directory + "/Tips"

tests/Infrastructure/EventLoggingManager/test_EventLoggingManager.py

@@ -1,5 +1,5 @@
 import unittest
-from unittest.mock import MagicMock
+from unittest.mock import call, MagicMock
 
 from Infrastructure.EventLoggingManager import EventLoggingManager
 from Infrastructure.FileUtilities import FileUtilities
@@ -17,6 +17,35 @@ def test_log_file_should_be_created_if_doesnt_exist(self):
 
         file_utility.create_file.assert_called_with(file_utility.get_root_path() + '\\MobTimerEvents.log')
 
+    def test_log_file_should_not_create_if_file_exists(self):
+        file_utility = FileUtilities()
+        file_utility.get_root_path = MagicMock(return_value='beginning of file path')
+        file_utility.file_exists = MagicMock(return_value=True)
+        file_utility.create_file = MagicMock(return_value=True)
+
+        EventLoggingManager(file_utility)
+
+        file_utility.create_file.assert_not_called()
+
+    def test_log_file_should_append_to_log(self):
+        file_utility = FileUtilities()
+        file_utility.get_root_path = MagicMock(return_value='beginning of file path')
+        file_utility.file_exists = MagicMock(return_value=True)
+        file_utility.create_file = MagicMock(return_value=True)
+        file_utility.append = MagicMock()
+        logger = EventLoggingManager(file_utility)
+
+        test_data = ["Hello world 1", "Hello world 2"]
+
+        for entry in test_data:
+            logger.log(entry)
+        calls = []
+
+        for entry in test_data:
+            calls.append(call('beginning of file path\\MobTimerEvents.log', '\n'+entry))
+
+        file_utility.append.assert_has_calls(calls)
+
 
 if __name__ == '__main__':
     unittest.main()

tests/Infrastructure/TipsManager/test_TipsManager.py

@@ -27,6 +27,15 @@ def test_random_tip_from_file_second(self):
         result = tips_manager.get_random_tip()
         self.assertEqual(result, 'TestTips.txt: Customer collaboration over contract negotiation\n')
 
+    def test_random_tip_from_file_second_alternate_slashes(self):
+        seed = 1
+        dirname = os.path.dirname(__file__)
+        path = self.go_two_dirs_up(dirname) + "\\Tips"
+        path = path.replace("\\", "/")
+        tips_manager = TipsManager(seed, path)
+        result = tips_manager.get_random_tip()
+        self.assertEqual(result, 'TestTips.txt: Customer collaboration over contract negotiation\n')
+
 
 if __name__ == '__main__':
     unittest.main()