F Event logging manager now records time stamps

Author: Pipeline

Infrastructure/EventLoggingManager.py

@@ -3,12 +3,14 @@
 
 class EventLoggingManager:
 
-    def __init__(self, file_utility):
+    def __init__(self, file_utility, date_time_utility):
         self.file_utility = file_utility
         self.file_path = self.file_utility.go_up_dirs(self.file_utility.get_root_path(), 1) + "\\MobTimerEvents.log"
 
+        self.date_time_utility = date_time_utility
+
         if not self.file_utility.file_exists(self.file_path):
             self.file_utility.create_file(self.file_path)
 
     def log(self, data):
-        self.file_utility.append(self.file_path, '\n' + data)
+        self.file_utility.append(self.file_path, f'\n{self.date_time_utility.get_timestamp()} {data}')

README.md

@@ -31,6 +31,7 @@ Run BuildMobTimer.py
 
 # Kanban
 * Make it easy to track time actually working
+  * Logs should have timestamps
   * log when mobber added and removed
   * enable/disable time tracking via the config file
   * define time types in the config file (Learning Time / Development Time etc...)

tests/Infrastructure/EventLoggingManager/test_EventLoggingManager.py

@@ -1,6 +1,7 @@
 import unittest
-from unittest.mock import call, MagicMock
+from unittest.mock import call, MagicMock, Mock
 
+from Infrastructure.DateTimeUtility import DateTimeUtility
 from Infrastructure.EventLoggingManager import EventLoggingManager
 from Infrastructure.FileUtilities import FileUtilities
 
@@ -13,8 +14,8 @@ def test_log_file_should_be_created_if_doesnt_exist(self):
         file_utility.get_root_path = MagicMock(return_value=beginning_of_file_path + "\\Infrastructure")
         file_utility.file_exists = MagicMock(return_value=False)
         file_utility.create_file = MagicMock(return_value=True)
-
-        EventLoggingManager(file_utility)
+        date_time_utility = DateTimeUtility()
+        EventLoggingManager(file_utility,date_time_utility)
 
         file_utility.create_file.assert_called_with(beginning_of_file_path + '\\MobTimerEvents.log')
 
@@ -24,7 +25,8 @@ def test_log_file_should_not_create_if_file_exists(self):
         file_utility.file_exists = MagicMock(return_value=True)
         file_utility.create_file = MagicMock(return_value=True)
 
-        EventLoggingManager(file_utility)
+        date_time_utility = DateTimeUtility()
+        EventLoggingManager(file_utility, date_time_utility)
 
         file_utility.create_file.assert_not_called()
 
@@ -35,16 +37,22 @@ def test_log_file_should_append_to_log(self):
         file_utility.file_exists = MagicMock(return_value=True)
         file_utility.create_file = MagicMock(return_value=True)
         file_utility.append = MagicMock()
-        logger = EventLoggingManager(file_utility)
+        date_time_utility = DateTimeUtility()
+
+        timestamps = [1594823426.159446, 1594123426.159447, 1594654426.159448]
+        date_time_utility.get_timestamp = Mock()
+        date_time_utility.get_timestamp.side_effect = timestamps
+        logger = EventLoggingManager(file_utility, date_time_utility)
 
         test_data = ["Hello world 1", "Hello world 2"]
 
         for entry in test_data:
             logger.log(entry)
         calls = []
-
+        index = 0
         for entry in test_data:
-            calls.append(call(beginning_of_file_path +'\\MobTimerEvents.log', '\n'+entry))
+            calls.append(call(f'{beginning_of_file_path}\\MobTimerEvents.log', f'\n{timestamps[index]} {entry}'))
+            index += 1
 
         file_utility.append.assert_has_calls(calls)