R - Replaced static method with instance method on FileUtilities and mocked it in the test

Author: Pipeline

Infrastructure/EventLoggingManager.py

@@ -0,0 +1,9 @@
+from Infrastructure.FileUtilities import FileUtilities
+
+
+class EventLoggingManager:
+
+    def __init__(self, file_utility):
+        file_path = file_utility.get_root_path() + "\\filename.txt"
+        if not file_utility.file_exists(file_path):
+            file_utility.create_file(file_path)

Infrastructure/FileUtilities.py

@@ -11,8 +11,7 @@ def main_is_frozen():
                hasattr(sys, "importers") # old py2exe
                or imp.is_frozen("__main__")) # tools/freeze
 
-    @staticmethod
-    def get_root_path():
+    def get_root_path(self):
         if FileUtilities.main_is_frozen():
             return os.path.dirname(sys.executable)
         return os.path.dirname(os.path.realpath(__file__))

Infrastructure/SessionManager.py

@@ -7,6 +7,7 @@
 class SessionManager(object):
     def __init__(self, uuid_generator):
         self.uuid_generator = uuid_generator
+        self.file_utilities = FileUtilities()
 
     def create_session(self):
         session_id = self.uuid_generator.uuid1()
@@ -16,7 +17,7 @@ def create_session(self):
         file = open(directory + session_id.__str__(), 'w+')
 
     def get_sessions_path(self):
-        directory = (FileUtilities.get_root_path() + "/Sessions/")
+        directory = (self.file_utilities.get_root_path() + "/Sessions/")
         if not os.path.exists(directory):
             os.makedirs(directory)
         return directory

tests/Infrastructure/EventLoggingManager/test_EventLoggingManager.py

@@ -1,19 +1,12 @@
 import unittest
 from unittest.mock import MagicMock
-from approvaltests.approvals import verify
 
+from Infrastructure.EventLoggingManager import EventLoggingManager
 from Infrastructure.FileUtilities import FileUtilities
-from Infrastructure.SettingsManager import SettingsManager
 
 
-class EventLoggingManager:
-
-    def __init__(self, file_utility):
-        file_path = FileUtilities.get_root_path() + "\\filename.txt"
-        if not file_utility.file_exists(file_path):
-            # file_utility.
-            file_utility.create_file(file_path)
-
+# 1. Mock remaining File Utilities function calls
+# 2. Choose a real name for the log file
 
 class TestsEventLoggingManager(unittest.TestCase):
 
@@ -22,13 +15,14 @@ def test_log_file_should_be_created_if_doesnt_exist(self):
 
         # Arrange: Make sure the file does not exist
         file_utility = FileUtilities()
+        file_utility.get_root_path = MagicMock(return_value='beginning of file path')
         file_utility.file_exists = MagicMock(return_value=False)
         file_utility.create_file = MagicMock(return_value=True)
         # Act: Instantiate EventLoggingManager
         event_logging_manager = EventLoggingManager(file_utility)
 
         # Assert: Verify the file exists
-        file_utility.create_file.assert_called_with(FileUtilities.get_root_path() + "\\filename.txt")
+        file_utility.create_file.assert_called_with(file_utility.get_root_path() + "\\filename.txt")
 
 
 if __name__ == '__main__':