Skip to content

GEOPY-2866: Research auto-scaling strategy for cross-gradient regularization terms#143

Merged
domfournier merged 5 commits into
release/GA_4.8from
GEOPY-2866
May 22, 2026
Merged

GEOPY-2866: Research auto-scaling strategy for cross-gradient regularization terms#143
domfournier merged 5 commits into
release/GA_4.8from
GEOPY-2866

Conversation

@domfournier
Copy link
Copy Markdown

@domfournier domfournier commented May 21, 2026

GEOPY-2866 - Research auto-scaling strategy for cross-gradient regularization terms

Copilot AI review requested due to automatic review settings May 21, 2026 19:50
@github-actions github-actions Bot changed the title GEOPY-2866 GEOPY-2866: Research auto-scaling strategy for cross-gradient regularization terms May 21, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the cross-gradient regularization to use the standard SimPEG weight infrastructure (via set_weights / W) and introduces a new joint-inversion directive intended to scale cross-gradient weights based on model-gradient derivative magnitudes.

Changes:

  • Refactors CrossGradient to construct and apply its weighting operator through a new W property and stored weights (including cell volumes).
  • Adds a new inversion directive to rescale cross-gradient weights at the end of each iteration.
  • Exposes the new directive through simpeg.directives.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
simpeg/regularization/cross_gradient.py Moves cross-gradient weighting to set_weights + cached W operator; updates default units value.
simpeg/directives/_sim_directives.py Adds a directive that computes a scale from model ranges and updates CrossGradient weights each iteration.
simpeg/directives/__init__.py Re-exports the new directive from the top-level directives package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread simpeg/regularization/cross_gradient.py
Comment thread simpeg/directives/_sim_directives.py Outdated
Comment thread simpeg/directives/_sim_directives.py Outdated
Comment thread simpeg/directives/_sim_directives.py
Comment thread simpeg/directives/__init__.py Outdated
@domfournier domfournier merged commit 78bced0 into release/GA_4.8 May 22, 2026
12 checks passed
@domfournier domfournier deleted the GEOPY-2866 branch May 22, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants