Merge pull request #25 from MiniMax-AI-Dev/feat/eslint-typescript

RyanLee-Dev · web-flow · commit f77fa162b2da · 2026-04-03T05:06:06.000+08:00
feat: add TypeScript ESLint and clean up unused code
diff --git a/build.ts b/build.ts
@@ -1,6 +1,7 @@
 import { readFileSync, writeFileSync } from 'fs';
 
-const VERSION = process.env.VERSION ?? 'dev';
+const pkg = JSON.parse(readFileSync('package.json', 'utf-8'));
+const VERSION = process.env.VERSION ?? pkg.version;
 const OUT = 'dist/minimax.mjs';
 
 await Bun.build({
diff --git a/bun.lock b/bun.lock
diff --git a/eslint.config.js b/eslint.config.js
@@ -0,0 +1,19 @@
+import eslint from '@eslint/js';
+import tseslint from 'typescript-eslint';
+
+export default tseslint.config(
+  eslint.configs.recommended,
+  ...tseslint.configs.recommended,
+  {
+    files: ['src/**/*.ts', 'test/**/*.ts', 'build.ts'],
+  },
+  {
+    ignores: ['dist/', 'node_modules/'],
+  },
+  {
+    rules: {
+      '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
+      '@typescript-eslint/no-explicit-any': 'warn',
+    },
+  },
+);
diff --git a/package.json b/package.json
@@ -3,8 +3,12 @@
   "version": "0.3.1",
   "description": "CLI for the MiniMax AI Platform",
   "type": "module",
-  "engines": { "node": ">=18" },
-  "bin": { "minimax": "./dist/minimax.mjs" },
+  "engines": {
+    "node": ">=18"
+  },
+  "bin": {
+    "minimax": "./dist/minimax.mjs"
+  },
   "files": ["dist/minimax.mjs"],
   "scripts": {
     "dev": "bun run src/main.ts",
@@ -20,8 +24,10 @@
     "@clack/prompts": "^0.7.0"
   },
   "devDependencies": {
-    "typescript": "^5.8.3",
+    "@eslint/js": "^9.0.0",
     "@types/bun": "latest",
-    "eslint": "^9.24.0"
+    "eslint": "^9.24.0",
+    "typescript": "^5.8.3",
+    "typescript-eslint": "^8.58.0"
   }
 }
diff --git a/src/args.ts b/src/args.ts
@@ -76,7 +76,7 @@ export function parseFlags(argv: string[], options: OptionDef[]): GlobalFlags {
     const arg = argv[i]!;
 
     if (arg === '--help' || arg === '-h') { flags.help = true; i++; continue; }
-    if (arg === '--') { i++; break; }
+    if (arg === '--') { break; }
 
     if (arg.startsWith('--')) {
       const eqIdx = arg.indexOf('=');
diff --git a/src/commands/auth/login.ts b/src/commands/auth/login.ts
@@ -5,7 +5,7 @@ import { saveCredentials } from '../../auth/credentials';
 import { startBrowserFlow, startDeviceCodeFlow } from '../../auth/oauth';
 import { requestJson } from '../../client/http';
 import { quotaEndpoint } from '../../client/endpoints';
-import { formatOutput } from '../../output/formatter';
+
 import { getConfigPath } from '../../config/paths';
 import { readConfigFile, writeConfigFile } from '../../config/loader';
 import { isInteractive } from '../../utils/env';
diff --git a/src/commands/auth/logout.ts b/src/commands/auth/logout.ts
@@ -16,7 +16,7 @@ export default defineCommand({
     'minimax auth logout --dry-run',
     'minimax auth logout --yes',
   ],
-  async run(config: Config, flags: GlobalFlags) {
+  async run(config: Config, _flags: GlobalFlags) {
     const creds = await loadCredentials();
     const fileConfig = readConfigFile();
     const hasConfigKey = !!fileConfig.api_key;
diff --git a/src/commands/auth/refresh.ts b/src/commands/auth/refresh.ts
@@ -15,7 +15,7 @@ export default defineCommand({
   examples: [
     'minimax auth refresh',
   ],
-  async run(config: Config, flags: GlobalFlags) {
+  async run(config: Config, _flags: GlobalFlags) {
     const creds = await loadCredentials();
 
     if (!creds) {
diff --git a/src/commands/auth/status.ts b/src/commands/auth/status.ts
@@ -16,7 +16,7 @@ export default defineCommand({
     'minimax auth status',
     'minimax auth status --output json',
   ],
-  async run(config: Config, flags: GlobalFlags) {
+  async run(config: Config, _flags: GlobalFlags) {
     try {
       const credential = await resolveCredential(config);
       const format = detectOutputFormat(config.output);
diff --git a/src/commands/config/show.ts b/src/commands/config/show.ts
@@ -13,7 +13,7 @@ export default defineCommand({
     'minimax config show',
     'minimax config show --output json',
   ],
-  async run(config: Config, flags: GlobalFlags) {
+  async run(config: Config, _flags: GlobalFlags) {
     const file = loadConfigFile();
     const format = detectOutputFormat(config.output);
 
diff --git a/src/commands/file/delete.ts b/src/commands/file/delete.ts
@@ -1,6 +1,4 @@
 import { defineCommand } from '../../command';
-import { CLIError } from '../../errors/base';
-import { ExitCode } from '../../errors/codes';
 import { requestJson } from '../../client/http';
 import { fileDeleteEndpoint } from '../../client/endpoints';
 import { formatOutput, detectOutputFormat } from '../../output/formatter';
diff --git a/src/commands/file/list.ts b/src/commands/file/list.ts
@@ -14,7 +14,7 @@ export default defineCommand({
     'minimax file list',
     'minimax file list --output json',
   ],
-  async run(config: Config, flags: GlobalFlags) {
+  async run(config: Config, _flags: GlobalFlags) {
     const format = detectOutputFormat(config.output);
 
     if (config.dryRun) {
diff --git a/src/commands/image/generate.ts b/src/commands/image/generate.ts
@@ -1,6 +1,4 @@
 import { defineCommand } from '../../command';
-import { CLIError } from '../../errors/base';
-import { ExitCode } from '../../errors/codes';
 import { requestJson } from '../../client/http';
 import { imageEndpoint } from '../../client/endpoints';
 import { downloadFile } from '../../files/download';
diff --git a/src/commands/quota/show.ts b/src/commands/quota/show.ts
@@ -2,7 +2,6 @@ import { defineCommand } from '../../command';
 import { requestJson } from '../../client/http';
 import { quotaEndpoint } from '../../client/endpoints';
 import { formatOutput, detectOutputFormat } from '../../output/formatter';
-import { formatTable } from '../../output/text';
 import type { Config } from '../../config/schema';
 import type { GlobalFlags } from '../../types/flags';
 
@@ -106,6 +105,7 @@ function isCJK(code: number): boolean {
 
 /** Visible column width of a plain string (ANSI-stripped, CJK = 2 cols) */
 function displayWidth(s: string): number {
+  // eslint-disable-next-line no-control-regex
   const plain = s.replace(/\x1b\[[0-9;]*m/g, '');
   let w = 0;
   for (const ch of plain) {
diff --git a/src/commands/search/query.ts b/src/commands/search/query.ts
@@ -2,7 +2,6 @@ import { defineCommand } from '../../command';
 import { requestJson } from '../../client/http';
 import { searchEndpoint } from '../../client/endpoints';
 import { formatOutput, detectOutputFormat } from '../../output/formatter';
-import { formatTable } from '../../output/text';
 import { CLIError } from '../../errors/base';
 import { ExitCode } from '../../errors/codes';
 import type { Config } from '../../config/schema';
diff --git a/src/commands/text/chat.ts b/src/commands/text/chat.ts
@@ -1,6 +1,4 @@
 import { defineCommand } from '../../command';
-import { CLIError } from '../../errors/base';
-import { ExitCode } from '../../errors/codes';
 import { request, requestJson } from '../../client/http';
 import { chatEndpoint } from '../../client/endpoints';
 import { parseSSE } from '../../client/stream';
@@ -100,7 +98,8 @@ export default defineCommand({
     'minimax text chat --message "Hello" --output json',
   ],
   async run(config: Config, flags: GlobalFlags) {
-    let { system, messages } = parseMessages(flags);
+    const { system, messages: parsedMessages } = parseMessages(flags);
+    let messages = parsedMessages;
 
     if (messages.length === 0) {
       if (isInteractive({ nonInteractive: config.nonInteractive })) {
diff --git a/src/commands/video/generate.ts b/src/commands/video/generate.ts
@@ -159,7 +159,7 @@ export default defineCommand({
     if (!existsSync(destDir)) mkdirSync(destDir, { recursive: true });
     const destPath = join(destDir, `${taskId}.mp4`);
 
-    const { size } = await downloadFile(downloadUrl, destPath, { quiet: config.quiet });
+    await downloadFile(downloadUrl, destPath, { quiet: config.quiet });
 
     // Pure local path output (stdout stays clean for piping)
     process.stdout.write(destPath);
diff --git a/src/commands/vision/describe.ts b/src/commands/vision/describe.ts
@@ -9,7 +9,7 @@ import type { GlobalFlags } from '../../types/flags';
 import { readFileSync, existsSync } from 'fs';
 import { extname } from 'path';
 import { isInteractive } from '../../utils/env';
-import { promptText, failIfMissing } from '../../utils/prompt';
+import { promptText } from '../../utils/prompt';
 
 interface VlmResponse {
   content: string;
@@ -101,7 +101,7 @@ export default defineCommand({
     }
 
     const url = vlmEndpoint(config.baseUrl);
-    let body: Record<string, unknown> = { prompt };
+    const body: Record<string, unknown> = { prompt };
 
     if (fileId) {
       // Skip base64: pass fileId directly to the API
diff --git a/src/update/checker.ts b/src/update/checker.ts
@@ -1,5 +1,5 @@
 import { join } from 'path';
-import { readFileSync, writeFileSync, existsSync } from 'fs';
+import { readFileSync, writeFileSync } from 'fs';
 import { getConfigDir } from '../config/paths';
 
 const STATE_FILE = () => join(getConfigDir(), 'update-state.json');
diff --git a/src/update/self-update.ts b/src/update/self-update.ts
@@ -25,7 +25,7 @@ export interface UpdateTarget {
 
 export type Channel = 'stable' | 'latest' | string; // string = exact version tag
 
-function detectPlatform(): string {
+async function detectPlatform(): Promise<string> {
   const os = process.platform;
   const arch = process.arch;
 
@@ -42,7 +42,7 @@ function detectPlatform(): string {
   // Detect musl on Linux
   if (mappedOs === 'linux') {
     try {
-      const { execSync } = require('child_process') as typeof import('child_process');
+      const { execSync } = await import('child_process');
       const ldd = execSync('ldd /bin/ls 2>&1', { encoding: 'utf-8' });
       if (ldd.includes('musl')) return `linux-${mappedArch}-musl`;
     } catch { /* non-fatal */ }
@@ -130,7 +130,7 @@ async function downloadFile(url: string, dest: string, onProgress?: (pct: number
 }
 
 export async function resolveUpdateTarget(channel: Channel): Promise<UpdateTarget> {
-  const platform = detectPlatform();
+  const platform = await detectPlatform();
   const version = await resolveVersion(channel);
   const manifest = await fetchManifest(version);
 
diff --git a/src/utils/prompt.ts b/src/utils/prompt.ts
@@ -30,6 +30,7 @@ export async function promptText(options: {
 
   const { defaultValue, message } = options;
   const inquirer = await import('@clack/prompts');
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const val = await (inquirer as any).text({
     message,
     default: defaultValue,
@@ -51,6 +52,7 @@ export async function promptConfirm(options: {
 
   const { message } = options;
   const inquirer = await import('@clack/prompts');
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const val = await (inquirer as any).confirm({ message });
 
   if (typeof val === 'symbol') return undefined;
diff --git a/src/utils/schema.ts b/src/utils/schema.ts
@@ -1,4 +1,4 @@
-import type { Command, OptionDef } from '../command';
+import type { Command } from '../command';
 
 /**
  * Parse a CLI flag string (e.g. "--prompt <text>", "--stream") into
diff --git a/test/auth/resolver.test.ts b/test/auth/resolver.test.ts
diff --git a/test/commands/text/chat.test.ts b/test/commands/text/chat.test.ts
