Skip to content

Commit f0bd794

Browse files
committed
* Revert back function name
* Simplify project_versions parameter
1 parent ef7bfb9 commit f0bd794

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

mergin/client.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -754,7 +754,7 @@ def project_versions_count(self, project_path):
754754
resp_json = json.load(resp)
755755
return resp_json["count"]
756756

757-
def project_versions_in_range(self, project_path, since=None, to=None):
757+
def project_versions(self, project_path, since=1, to=None):
758758
"""
759759
Get records of project's versions (history) in ascending order.
760760
If neither 'since' nor 'to' is specified it will return all versions.
@@ -773,8 +773,6 @@ def project_versions_in_range(self, project_path, since=None, to=None):
773773

774774
if type(since) == str:
775775
num_since = int_version(since)
776-
elif since == None:
777-
num_since = 1
778776
else:
779777
# keep the since parameter as is
780778
num_since = since
@@ -792,8 +790,7 @@ def project_versions_in_range(self, project_path, since=None, to=None):
792790
num_to = self.project_versions_count(project_path)
793791
latest_version = int_version(versions[-1]["name"])
794792
if latest_version < num_to:
795-
# add yield here
796-
versions += self.project_versions_in_range(project_path, f"v{latest_version+1}", f"v{num_to}")
793+
versions += self.project_versions(project_path, f"v{latest_version+1}", f"v{num_to}")
797794
else:
798795
end_page = math.ceil(num_to / per_page)
799796
for page in range(start_page, end_page + 1):

mergin/report.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ def create_report(mc, directory, since, to, out_file):
216216
mp = MerginProject(directory)
217217
project = mp.project_full_name()
218218
mp.log.info(f"--- Creating changesets report for {project} from {since} to {to if to else 'latest'} versions ----")
219-
versions = mc.project_versions_in_range(project, since, to if to else None)
219+
versions = mc.project_versions(project, since, to if to else None)
220220
versions_map = {v["name"]: v for v in versions}
221221
headers = ["file", "table", "author", "date", "time", "version", "operation", "length", "area", "count"]
222222
records = []

mergin/test/test_client.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1989,23 +1989,23 @@ def test_project_versions_list(mc):
19891989
assert project_info["version"] == "v5"
19901990

19911991
# get all versions
1992-
versions = mc.project_versions_in_range(project)
1992+
versions = mc.project_versions(project)
19931993
assert len(versions) == 5
19941994
assert versions[0]["name"] == "v1"
19951995
assert versions[-1]["name"] == "v5"
19961996

19971997
# get first 3 versions
1998-
versions = mc.project_versions_in_range(project, to="v3")
1998+
versions = mc.project_versions(project, to="v3")
19991999
assert len(versions) == 3
20002000
assert versions[-1]["name"] == "v3"
20012001

20022002
# get last 2 versions
2003-
versions = mc.project_versions_in_range(project, since="v4")
2003+
versions = mc.project_versions(project, since="v4")
20042004
assert len(versions) == 2
20052005
assert versions[0]["name"] == "v4"
20062006

20072007
# get range v2-v4
2008-
versions = mc.project_versions_in_range(project, since="v2", to="v4")
2008+
versions = mc.project_versions(project, since="v2", to="v4")
20092009
assert len(versions) == 3
20102010
assert versions[0]["name"] == "v2"
20112011
assert versions[-1]["name"] == "v4"

0 commit comments

Comments
 (0)