Skip to content

Commit 9aa18d5

Browse files
authored
Merge pull request #239 from MerginMaps/fix-tests-2025.4.1
Fix tests 2025.4.1
2 parents 11e7ce8 + dee0eff commit 9aa18d5

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

mergin/test/test_client.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2777,14 +2777,6 @@ def test_access_management(mc: MerginClient, mc2: MerginClient):
27772777
# test permissions - a different client cannot update the role
27782778
with pytest.raises(ClientError, match=f"You do not have admin permissions to workspace"):
27792779
mc2.update_workspace_member(workspace_id, new_user["id"], ws_role)
2780-
# remove workspace member
2781-
mc.remove_workspace_member(workspace_id, new_user["id"])
2782-
workspace_members = mc.list_workspace_members(workspace_id)
2783-
assert not any(m["id"] == new_user["id"] for m in workspace_members)
2784-
# duplicated call
2785-
with pytest.raises(ClientError) as exc_info:
2786-
mc.remove_workspace_member(workspace_id, new_user["id"])
2787-
assert exc_info.value.http_error == 404
27882780
# add project
27892781
test_project_name = "test_collaborators"
27902782
test_project_fullname = API_USER + "/" + test_project_name
@@ -2810,7 +2802,8 @@ def test_access_management(mc: MerginClient, mc2: MerginClient):
28102802
collaborators = mc.list_project_collaborators(test_project_id)
28112803
updated_collaborator = next((c for c in collaborators if c["id"] == new_user["id"]))
28122804
assert updated_collaborator["project_role"] == updated_role.value
2813-
# remove project collaborator
2805+
# remove project collaborator, add this user guest first to make sure it can be removed from project collaborators
2806+
mc.update_workspace_member(workspace_id, new_user["id"], WorkspaceRole.GUEST)
28142807
mc.remove_project_collaborator(test_project_id, new_user["id"])
28152808
collaborators = mc.list_project_collaborators(test_project_id)
28162809
assert not any(c["id"] == new_user["id"] for c in collaborators)
@@ -2832,3 +2825,11 @@ def test_access_management(mc: MerginClient, mc2: MerginClient):
28322825
{"limits_override": {"projects": orig_projects_limit}},
28332826
json_headers,
28342827
)
2828+
# remove workspace member
2829+
mc.remove_workspace_member(workspace_id, new_user["id"])
2830+
workspace_members = mc.list_workspace_members(workspace_id)
2831+
assert not any(m["id"] == new_user["id"] for m in workspace_members)
2832+
# duplicated call
2833+
with pytest.raises(ClientError) as exc_info:
2834+
mc.remove_workspace_member(workspace_id, new_user["id"])
2835+
assert exc_info.value.http_error == 404

0 commit comments

Comments
 (0)