Improve error handling - show custom details

Author: harminius

mergin/client.py

@@ -210,9 +210,20 @@ def _do_request(self, request):
         except urllib.error.HTTPError as e:
             server_response = json.load(e)
 
-            # We first to try to get the value from the response otherwise we set a default value
-            err_detail = server_response.get("detail", e.read().decode("utf-8"))
             server_code = server_response.get("code", None)
+            # Try to get error detail
+            if isinstance(server_response, dict):
+                if "detail" in server_response:
+                    err_detail = server_response["detail"]
+                else:
+                    # Extract all field-specific errors and format them
+                    err_detail = "\n".join(
+                        f"{key}: {', '.join(map(str, value))}"
+                        for key, value in server_response.items()
+                        if isinstance(value, list)
+                    ) or str(server_response)  # Fallback to raw response if structure is unexpected
+            else:
+                err_detail = str(server_response)
 
             raise ClientError(
                 detail=err_detail,

mergin/test/test_client.py

@@ -2746,11 +2746,16 @@ def test_workspace_requests(mc2: MerginClient):
 
 
 def test_access_management(mc: MerginClient, mc2: MerginClient):
-    # create a user in the workspace
+    # create a user in the workspace -
     workspace_id = next((w["id"] for w in mc.workspaces_list() if w["name"] == mc.username()))
+    ws_role = WorkspaceRole.WRITER
     email = "create_user" + str(random.randint(1000, 9999)) + "@client.py"
+    # returning meaningful error when requirements are not met
+    password = "1234"
+    with pytest.raises(ClientError, match=f"Passwords must be at least 8 characters long."):
+        mc.create_user(email, password, workspace_id, ws_role)
+    # strong password
     password = "Il0vemergin"
-    ws_role = WorkspaceRole.WRITER
     user_info = mc.create_user(email, password, workspace_id, ws_role)
     assert user_info["email"] == email
     assert user_info["receive_notifications"] is False