updatenotification is broken

[khassel]

[2026-05-03 15:59:50.543] [ERROR] [updatenotification] Failed to get git revisions for MagicMirror: Error: Command failed: git rev-list --ancestry-path --count 3335781..d20306c  develop
fatal: ambiguous argument '3335781..d20306c  develop': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

Manually executing works:

/opt/magic_mirror $ git rev-list --ancestry-path --count 3335781..d20306c  develop
2

[khassel]

the problem is that refDiff=3335781..d20306c develop can contain spaces.

await this.execGit(repo.folder, "rev-list", "--ancestry-path", "--count", refDiff);

fails, a test with hardcoded values works:

await this.execGit(repo.folder, "rev-list", "--ancestry-path", "--count", "3335781..d20306c", "develop");

Introduced with #4115

[khassel]

one solution: using "args" as string param containing the whole command and do the split inside execGit. What do you think @KristjanESPERANTO ?

[KristjanESPERANTO]

Sorry, obviously I didn't review my PR thoroughly enough.

Let me take a look at it.

[KristjanESPERANTO]

using "args" as string param containing the whole command and do the split inside execGit.

Good approach, would have solved the problem too. I went with column-based parsing and opened PR #4138 for it. What do you think?