[Bug] Openmeteo weather forecast stuck in the past

[rejas]

Environment

MagicMirror² version: develop

Which start option are you using?

node --run start

Are you using PM2?

No

Module

weather

Have you tried disabling other modules?

• Yes
• No

Have you searched if someone else has already reported the issue on the forum or in the issues?

• Yes

What did you do?

Configuration

		{
			module: "weather",
			//disabled: true,
			position: "top_left",
			config: {
				weatherProvider: "openmeteo",
				appendLocationNameToHeader: false,
				fade: false,
				ignoreToday: false,
				type: "forecast",
				location: "Berlin",
				lat: 52.5012,
				lon: 13.4789
			}
		}

Steps to reproduce the issue:

Start the weather forecast, wait a day, still on the same day as before.

What did you expect to happen?

Weather forecast gets updated each day

What actually happened?

On sunday it still thinks its thursday

Additional comments

Very likely the url for fetching the weather is only updated on startup of mm. So the start-data parameter is never updated, sicne the url stays the same for each call.

	#initializeFetcher () {
		const url = this.#getUrl();
...

	#getUrl () {
		return `${this.config.apiBase}/forecast?${this.#getQueryParameters()}`;
	}

Maybe other fetcher users have the same problem?

Participation

• I am willing to submit a pull request for this change.

[KristjanESPERANTO]

Oh, I introduced that one with #4032. Sorry! I've already almost finished the fix. Just a few final test left.