A couple of utilisations of std::optional#3346
Merged
Merged
Conversation
Restricted to those scenarios where either a sentinel value did not make sense, or requisite refactoring was minimal. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant to #2585.
Claude was not as eager to make use of this functionality as I was. It did find the GLM variance groups that are
std::optional-ed in #3313, which I will leave to that PR to change. It also found the DWI and phase encoding scheme extractions done in #3313, though unlike me it opted out of those due to complexity. I think my current instinct is liking this functionality because it implicitly communicates the prospect of an absence of data far more so than a sentinel value, whereas maybe the AI is less concerned with the limitations of human cognition.