fixelconnectivity: New option -normalise#3338
Draft
Lestropie wants to merge 1 commit into
Draft
Conversation
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| void set_count_path(std::string_view path); | ||
| void set_extent_path(std::string_view path); | ||
| void save(std::string_view path) const; | ||
| void save(std::string_view path, const bool normalise) const; |
There was a problem hiding this comment.
warning: parameter 'normalise' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Suggested change
| void save(std::string_view path, const bool normalise) const; | |
| void save(std::string_view path, bool normalise) const; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3337.
Plz test @ppruc.
Outstanding tasks hence listed as draft PR:
Before committing to public code would want to check that a user providing such a matrix to eg. fixelfilter or fixelcfestats would result in either identical results or obviously erroneous results, not something that is subtlely wrong.
Describe consequences of presence or absence of normalisation in command documentation.