population_template: Fix linear registration with -info / -debug#3322
Open
Lestropie wants to merge 1 commit into
Open
population_template: Fix linear registration with -info / -debug#3322Lestropie wants to merge 1 commit into
Lestropie wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When run with
-infoor-debug,population_templateinstructsmrregisterto generate additional log files in the scratch directory. However the derivation of the filesystem path for that file attempts to include a string from "the currently processed contrast". This is erroneous asmrregisteris run once taking as input all contrasts. The relevant code is not inside of aforloop over contrasts. So indexcidis invalid and the code emitsIndexException: string index out of range.Discovered on
dev.With refactoring, the filesystem path is first determined, and then the choice of whether to insert it into the
mrregistercall is made subsequently.Since it's the construction of the filesystem path that yields the Exception, the issue was encountered even when
population_templatewas run at default verbosity.The bug is however present on
masterso should be rectified there.