Math::SH: Improve numerical robustness to value() and delta() functions#3307
Open
Lestropie wants to merge 1 commit into
Open
Math::SH: Improve numerical robustness to value() and delta() functions#3307Lestropie wants to merge 1 commit into
Lestropie wants to merge 1 commit into
Conversation
Echoes changes made in #3299 to the get_peak() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving CI testing issues in #2451 on Mac turned out to require use of the same
std::hypot()function as was introduced in #3299 forMath::SH::get_peak()function, but in theMath::SH::value()functions (both precomputed and not). It is therefore likely that exactly the same numerical imprecisions manifest there, only that they are not iterative and not detected with existing tests, whereas in #2451 testing sampling of FOD amplitudes along streamline trajectories does manifest it.I therefore consider it to be a "bug" not previously detected that warrants back-propagation to
master.