FIX - Only variables should be passed by reference in usersettings.class.php on line 34

blondak · blondak · commit b144d21cb385 · 2017-09-06T21:03:37.000+02:00
diff --git a/include/classes/usersettings.class.php b/include/classes/usersettings.class.php
@@ -31,7 +31,8 @@ private function _storeValue($name, $value){
 			if (empty(self::$__SetSTMT)){
 				self::$__SetSTMT = $this->mysqli->prepare('REPLACE INTO '.$this->table.' (`account_id`, `name`, `value`) VALUES (?, ?, ?)');
 			}
-			if (!(self::$__SetSTMT && self::$__SetSTMT->bind_param('iss', $this->account_id, $name, serialize($value)) && self::$__SetSTMT->execute())) {
+			$val = serialize($value);
+			if (!(self::$__SetSTMT && self::$__SetSTMT->bind_param('iss', $this->account_id, $name, $val) && self::$__SetSTMT->execute())) {
 				$this->setErrorMessage($this->getErrorMsg('E0084', $this->table));
 				return $this->sqlError();
 			}

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,8 @@ private function _storeValue($name, $value){`
`31`	`31`	`if (empty(self::$__SetSTMT)){`
`32`	`32`	self::$__SetSTMT = $this->mysqli->prepare('REPLACE INTO '.$this->table.' (`account_id`, `name`, `value`) VALUES (?, ?, ?)');
`33`	`33`	`}`
`34`		`- if (!(self::$__SetSTMT && self::$__SetSTMT->bind_param('iss', $this->account_id, $name, serialize($value)) && self::$__SetSTMT->execute())) {`
	`34`	`+ $val = serialize($value);`
	`35`	`+ if (!(self::$__SetSTMT && self::$__SetSTMT->bind_param('iss', $this->account_id, $name, $val) && self::$__SetSTMT->execute())) {`
`35`	`36`	`$this->setErrorMessage($this->getErrorMsg('E0084', $this->table));`
`36`	`37`	`return $this->sqlError();`
`37`	`38`	`}`