25-ITP-SEP | Data Flows | Mohammed Abdoon

[M-Abdoon]

1 - Evidence that I have completed at least 6 katas in the Data Flows collection and at least 6 katas in the Array and Object Methods collection.
Link: Codewars Progress Checker

2 - A link to my GitHub repo and deployed Netlify site for the “TV Show Project".
Link to deployed Netfly site for the TV Show: TV Show Project
Link to my GitHub repo for the TV Show: TV Show Repo

3.1 - A link to my level 400 pull request for the “TV Show Project", to show both I and my partner contributed.
Link: TV Show Project Level 400 pull request

3.1 - 3 - A link to my level 500 pull request for the “TV Show Project".
Link: TV Show Project Level 500 pull request

4 - A link to my completed pull request for “Book Library Project", where I have responded to review feedback.
Link: Book Library Project

5 - A link to my issue for “LinkedIn Social Selling Index".
Link: LinkedIn Social Selling Index

6 - A screenshot showing that I took part in an online study session with at least one other trainee. This could be a video call, a Slack thread, or something else!
Screenshoot:

7 - A screenshot showing that I gave a demo in a demo session with particular members of staff present.
Photo:

[illicitonion]

A few things aren't quite right here:

1. Please include a link to the GitHub repo for your TV show project
2. On your TV show project, search doesn't quite work like I'd expect:
   1. If I go to the page, click on a TV show, then type something into search, it seems to show episodes for all shows, not the one I clicked into? And then the title is wrong, e.g. I searched for "pilot" and got shown "Mob City - SundefinedEundefined"
   2. If I select "American Dad!" from the drop-down, then search for "pilot", it shows me all episodes
3. Please include a link to your Book Library project PR, not to the issue in the CYF repo.

[M-Abdoon]

Hi Daniel, Thank you for your review. I have updated the issue and fixed the search problem. Thanks.

[illicitonion]

Fantastic, well done! If you re-submit your step link, I will approve it.

A few comments on your TV show project for you to consider:

1. Search on American Dad is still broken
2. Please format your code - right now the indentation (e.g. for setup) makes your code harder to read.
3. Your site currently has an XSS vulnerability because of your use of innerHTML with untrusted data. Have a read of https://medium.com/@sparklewebhelp/understanding-the-risks-of-using-inner-html-in-web-development-30d4fa67f815 and see if you can fix this.
4. You repeat your fallbacks for e.g. missing episode names a few times (e.g. on lines 110 and 213) - how could you avoid that?

[M-Abdoon]

Thank you @illicitonion , The American Dad show was a bit tricky because it included an episode without a summary, and I had assumed all episodes would have one, but that’s sorted now. I also cleaned up the indentation, fixed the XSS issue by stripping HTML tags, and created a new function to normalize episodes so the fallback logic only needs to be written once.

I could not re-submit the issue link because it tells that the link has been already approved.