Limit boolean-context checks to conditions

Author: kyoh86

script/core/diagnostics/boolean-context.lua

@@ -35,20 +35,6 @@ end
 
 ---@param source parser.object?
 ---@return boolean
-local function isConditionFilter(source)
-    if not source or not source.parent then
-        return false
-    end
-    local parent = source.parent
-    if parent.type ~= 'ifblock'
-    and parent.type ~= 'elseifblock'
-    and parent.type ~= 'while'
-    and parent.type ~= 'repeat' then
-        return false
-    end
-    return parent.filter == source
-end
-
 ---@param source parser.object?
 ---@param uri uri
 ---@param callback fun(result: diag.result)
@@ -92,23 +78,10 @@ return function (uri, callback)
         and source.filter.type == 'binary'
         and source.filter.op
         and (source.filter.op.type == 'and' or source.filter.op.type == 'or') then
+            checkExpression(source.filter[1], uri, callback)
+            checkExpression(source.filter[2], uri, callback)
             return
         end
         checkExpression(source.filter, uri, callback)
     end)
-
-    ---@async
-    guide.eachSourceType(state.ast, 'binary', function (source)
-        await.delay()
-        local op = source.op and source.op.type
-        if op ~= 'and' and op ~= 'or' then
-            return
-        end
-        if isConditionFilter(source) then
-            checkExpression(source[1], uri, callback)
-            checkExpression(source[2], uri, callback)
-            return
-        end
-        checkExpression(source[1], uri, callback)
-    end)
 end

test/diagnostics/boolean-context.lua

@@ -5,15 +5,7 @@ if <!a!> then end
 
 ---@type number
 local b
-if not b then end
-
----@type number
-local c
-local x = <!c!> or "3"
-
----@type false
-local d
-local y = d and "4"
+if <!b!> then end
 
 ---@type boolean
 local e
@@ -34,8 +26,4 @@ if <!h!> and true then end
 ---@type number
 local i
 if true and <!i!> then end
-
----@type any
-local f
-local z = f or "3"
 ]]